[Php55][Renaming] Handle rename string on combination StringClassName…

…ToClassConstantRector+RenameStringRector (#4869)

* [Php55][Renaming] Handle rename string on combination StringClassNameToClassConstantRector+RenameStringRector

* [ci-review] Rector Rectify

* it works 🎉

* fix

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

packages/NodeTypeResolver/Node/AttributeKey.php

@@ -133,6 +133,12 @@ final class AttributeKey
      */
     public const CREATED_BY_RULE = 'created_by_rule';
 
+    /**
+     * Helps with skipped below node
+     * @var string
+     */
+    public const SKIPPED_BY_RECTOR_RULE = 'skipped_rector_rule';
+
     /**
      * @var string
      */

src/ProcessAnalyzer/RectifiedAnalyzer.php

@@ -27,7 +27,11 @@ public function hasRectified(string $rectorClass, Node $node): bool
             return true;
         }
 
-        return $this->isJustReprintedOverlappedTokenStart($node, $originalNode);
+        if ($this->isJustReprintedOverlappedTokenStart($node, $originalNode)) {
+            return true;
+        }
+
+        return $node->getAttribute(AttributeKey::SKIPPED_BY_RECTOR_RULE) === $rectorClass;
     }
 
     /**

src/Rector/AbstractRector.php

@@ -195,11 +195,16 @@ final public function enterNode(Node $node): int|Node|null
         if (is_int($refactoredNode)) {
             $this->createdByRuleDecorator->decorate($node, $originalNode, static::class);
 
-            // notify this rule changing code
-            $rectorWithLineChange = new RectorWithLineChange(static::class, $originalNode->getLine());
-            $this->file->addRectorClassWithLine($rectorWithLineChange);
+            if (! in_array($refactoredNode, [NodeTraverser::DONT_TRAVERSE_CHILDREN, NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN], true)) {
+                // notify this rule changing code
+                $rectorWithLineChange = new RectorWithLineChange(static::class, $originalNode->getLine());
+                $this->file->addRectorClassWithLine($rectorWithLineChange);
 
-            return $refactoredNode;
+                return $refactoredNode;
+            }
+
+            $this->decorateCurrentAndChildren($node);
+            return null;
         }
 
         // nothing to change → continue
@@ -215,6 +220,26 @@ final public function enterNode(Node $node): int|Node|null
         return $this->postRefactorProcess($originalNode, $node, $refactoredNode, $filePath);
     }
 
+    private function decorateCurrentAndChildren(Node $node): void
+    {
+        // filter only types that
+        //    1. registered in getNodesTypes() method
+        //    2. different with current node type, as already decorated above
+        //
+        $types = array_filter(
+            $this->getNodeTypes(),
+            static fn (string $nodeType): bool => $nodeType !== $node::class
+        );
+        $this->traverseNodesWithCallable($node, static function (Node $subNode) use ($types) {
+            if (in_array($subNode::class, $types, true)) {
+                $subNode->setAttribute(AttributeKey::SKIPPED_BY_RECTOR_RULE, static::class);
+                $subNode->setAttribute(AttributeKey::SKIPPED_BY_RECTOR_RULE, static::class);
+            }
+
+            return null;
+        });
+    }
+
     /**
      * Replacing nodes in leaveNode() method avoids infinite recursion
      * see"infinite recursion" in /~https://github.com/nikic/PHP-Parser/blob/master/doc/component/Walking_the_AST.markdown

tests/Issues/RenameString/Fixture/rename_string.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\Core\Tests\Issues\DoubleRun\Fixture;
+
+final class RenameString
+{
+    public function run($variable)
+    {
+        return is_a(
+            $variable,
+            'Rector\Core\Tests\Issues\DoubleRun\Fixture\RenameString',
+            true
+        );
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Core\Tests\Issues\DoubleRun\Fixture;
+
+final class RenameString
+{
+    public function run($variable)
+    {
+        return is_a(
+            $variable,
+            'new test',
+            true
+        );
+    }
+}
+
+?>

tests/Issues/RenameString/RenameStringTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\RenameString;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RenameStringTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Issues/RenameString/config/configured_rule.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
+use Rector\Renaming\Rector\String_\RenameStringRector;
+
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(StringClassNameToClassConstantRector::class);
+
+    $rectorConfig->ruleWithConfiguration(
+        RenameStringRector::class,
+        [
+    		'Rector\Core\Tests\Issues\DoubleRun\Fixture\RenameString' => 'new test',
+        ]
+    );
+};