Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pteron36, open source 3x5_3 supporting layout #13313

Merged
merged 13 commits into from
Jul 1, 2021

Conversation

harshitgoel96
Copy link
Contributor

@harshitgoel96 harshitgoel96 commented Jun 23, 2021

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@harshitgoel96 harshitgoel96 changed the title Pteron36, open source 3x Pteron36, open source 3x5_3 supporting layout Jun 23, 2021
keyboards/pteron36/info.json Outdated Show resolved Hide resolved
keyboards/pteron36/pteron36.h Outdated Show resolved Hide resolved
keyboards/pteron36/pteron36.h Outdated Show resolved Hide resolved
keyboards/pteron36/readme.md Outdated Show resolved Hide resolved
keyboards/pteron36/readme.md Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team June 23, 2021 13:53
@harshitgoel96 harshitgoel96 requested review from fauxpark and removed request for a team June 23, 2021 16:08
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@harshitgoel96 harshitgoel96 requested a review from fauxpark June 24, 2021 04:31
@harshitgoel96
Copy link
Contributor Author

info.json fixed

@fauxpark fauxpark requested a review from a team June 24, 2021 04:39
@harshitgoel96 harshitgoel96 requested a review from drashna June 26, 2021 08:12
@harshitgoel96
Copy link
Contributor Author

i have added support for via, can i add that into this pr as well?

@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Jun 27, 2021
@harshitgoel96
Copy link
Contributor Author

support for via added in the same pr

keyboards/pteron36/readme.md Outdated Show resolved Hide resolved
keyboards/pteron36/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@harshitgoel96 harshitgoel96 requested a review from fauxpark June 28, 2021 04:34
keyboards/pteron36/readme.md Outdated Show resolved Hide resolved
@harshitgoel96 harshitgoel96 requested a review from fauxpark June 28, 2021 04:47
@fauxpark fauxpark requested a review from a team June 28, 2021 04:53
@drashna drashna merged commit 4168e10 into qmk:master Jul 1, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 2, 2021
* qmk/develop: (25 commits)
  [Core] Unite half-duplex and full-duplex serial drivers (qmk#13081)
  Add missing Quefrency layouts for QMK Configurator (qmk#13384)
  [Keyboard] Adding Via support to the GON NerD60 (qmk#13395)
  [Keymap] Add haervig userspace and keymaps (qmk#13362)
  Convert Dip Switch callbacks to boolean functions (qmk#13399)
  Changed Yeehaw Default Keymap (qmk#13341)
  [Docs] update Japanese translation of other_eclipse.md (qmk#12776)
  update Japanese translation of config_options.md (qmk#12695)
  Translated 'feature_advanced_keycodes.md'. (qmk#12454)
  [Docs] Japanese translation of docs/keycodes_basic.md (qmk#11044)
  Illusion Rosa: correct layout macro names (qmk#13387)
  FJLabs Midway60: physically arrange layout macro and fix info.json data (qmk#13386)
  Sanctified Dystopia: physically arrange layout macro (qmk#13385)
  Updates for keymap: ut472/stefanopace (qmk#13370)
  [Keyboard] update debounce time on kint boards (qmk#13351)
  [Keymap] RGB Timeout added to userspace (qmk#13339)
  [Keyboard][Bug] Fix LED indicators on Skeletn87 (qmk#13335)
  [Keyboard] Pteron36, open source 3x5_3 supporting layout (qmk#13313)
  Drashna's split updates (qmk#13350)
  [Keymap] Create bingocaller keymap for DZ60RGB-ANSI (qmk#13311)
  ...
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants