Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Japanese translation of docs/keycodes_basic.md #11044

Merged
merged 10 commits into from
Jul 1, 2021
Merged

[Docs] Japanese translation of docs/keycodes_basic.md #11044

merged 10 commits into from
Jul 1, 2021

Conversation

s-show
Copy link
Contributor

@s-show s-show commented Nov 27, 2020

Description

Add Japanese translation of docs/keycodes_basic.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@s-show
Copy link
Contributor Author

s-show commented Nov 27, 2020

#10192 review first.

@mtei mtei added the awaiting_pr Relies on another PR to be merged first label Nov 27, 2020
@stale
Copy link

stale bot commented Jan 11, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@s-show
Copy link
Contributor Author

s-show commented Mar 28, 2021

/~https://github.com/qmk/qmk_firmware/releases/tag/breakpoint_2021_05_29 による変更 ( #11343 ) を反映しました。#10192 のレビューも完了しましたので、このファイルのレビューもできるようになったと思います。
放置していて申し訳ありませんでした。

@mtei
Copy link
Contributor

mtei commented Apr 1, 2021

@umi-umi @shelaf @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

@mtei mtei removed the awaiting_pr Relies on another PR to be merged first label Apr 1, 2021
docs/ja/keycodes_basic.md Outdated Show resolved Hide resolved
|`KC_F23`|F23 |
|`KC_F24`|F24 |

## 句読点
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

句読点というと「、」「。」な印象が強いのでどうするといいか悩むところですね。少し表現を替えて「区切り文字」でもやや不適切に感じます。そもそも日本語にない表現なので完全にマッチする翻訳はなく、原文を離れた訳にしてしまうのも1つの手かなと感じます。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

富士通の FMV のマニュアルでキーボードの説明があり、そこでは、Enter や Tab 等のキーを「制御キー」と照会していますので、「制御キーと記号」という訳はどうでしょうか。
https://www.fmworld.net/biz/fmv/support/fmvmanual/0710-0803/5071s/02_toriatsukai7.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「句読点」「制御キー」はそれぞれ受ける印象の範囲が狭いあるいは別のものを想像してしまいそうな気がします。
さんざん悩んだ末にこれだというものを思いつけなかったのですが、「区切り文字」や「句読記号」ならまだ伝わりやすい気がします。

あるいは将来良い訳語がでてくることを期待して、Punctuation のままにしておくのもありかなと思います。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ロングマンの英英辞典で punctuation を検索しましたが、フレーズや文章の区切りという説明しかありませんでしたので、表中の Escape や Delete と意味が合わないですね。そもそも、カンマ・ピリオドと Delete・Escape が同じ表に収められているところに無理がある気もしますので、やむを得ず原文のままにしようかと思います。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なんとなく翻訳忘れに見えてしまうので、カタカナにしておくのもありかもしれません。

docs/ja/keycodes_basic.md Outdated Show resolved Hide resolved
docs/ja/keycodes_basic.md Outdated Show resolved Hide resolved
docs/ja/keycodes_basic.md Outdated Show resolved Hide resolved
docs/ja/keycodes_basic.md Outdated Show resolved Hide resolved
s-show and others added 5 commits April 15, 2021 22:48
Co-authored-by: shela <shelaf@users.noreply.github.com>
Co-authored-by: shela <shelaf@users.noreply.github.com>
Co-authored-by: shela <shelaf@users.noreply.github.com>
Co-authored-by: shela <shelaf@users.noreply.github.com>
Co-authored-by: shela <shelaf@users.noreply.github.com>
Copy link
Contributor

@umi-umi umi-umi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Punctuation の箇所を除いて、良いように思いますのでapproveします。

@mtei mtei requested a review from a team June 24, 2021 15:30
Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原文にある、(macOS) (Windows) の記述があちこち省かれているようですが、他のレビュアーさんが問題にしなかったので私も目をつぶります。

@mtei mtei requested a review from a team June 24, 2021 15:33
@shelaf
Copy link
Contributor

shelaf commented Jun 24, 2021

原文にある、(macOS) (Windows) の記述があちこち省かれているようですが、他のレビュアーさんが問題にしなかったので私も目をつぶります。

原文・翻訳ともに(macOS)は2カ所、(Windows)は該当なしで、問題はないように見えます。

@mtei
Copy link
Contributor

mtei commented Jun 24, 2021

そうですか?
おかしいな、手元ではこうなります。

 % git log -1 | cat
commit abd9387a519003c40bc33bdf336ea7d01eab0677
Author: s-show <s1shimz@gmail.com>
Date:   Mon Jun 14 23:31:22 2021

    update based on comment.

 % grep Window docs/keycodes_basic.md | wc -l
      15
 % grep Window docs/ja/keycodes_basic.md | wc -l
       3
 % grep macOS docs/keycodes_basic.md | wc -l 
      10
 % grep macOS docs/ja/keycodes_basic.md | wc -l
       3

@mtei
Copy link
Contributor

mtei commented Jun 24, 2021

あー、わかりました。この PR のブランチは、0.10.54 から分岐してましたが、翻訳内容は、0.11.25 なのですね。
git diff -w 0.10.54 0.11.25 docs/keycodes_basic.md で確認できました。

@mtei
Copy link
Contributor

mtei commented Jun 24, 2021

I think this is ready to merge.

@mtei mtei merged commit 882b90b into qmk:master Jul 1, 2021
@mtei
Copy link
Contributor

mtei commented Jul 1, 2021

Thanks!

cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Jul 2, 2021
* qmk/develop: (25 commits)
  [Core] Unite half-duplex and full-duplex serial drivers (qmk#13081)
  Add missing Quefrency layouts for QMK Configurator (qmk#13384)
  [Keyboard] Adding Via support to the GON NerD60 (qmk#13395)
  [Keymap] Add haervig userspace and keymaps (qmk#13362)
  Convert Dip Switch callbacks to boolean functions (qmk#13399)
  Changed Yeehaw Default Keymap (qmk#13341)
  [Docs] update Japanese translation of other_eclipse.md (qmk#12776)
  update Japanese translation of config_options.md (qmk#12695)
  Translated 'feature_advanced_keycodes.md'. (qmk#12454)
  [Docs] Japanese translation of docs/keycodes_basic.md (qmk#11044)
  Illusion Rosa: correct layout macro names (qmk#13387)
  FJLabs Midway60: physically arrange layout macro and fix info.json data (qmk#13386)
  Sanctified Dystopia: physically arrange layout macro (qmk#13385)
  Updates for keymap: ut472/stefanopace (qmk#13370)
  [Keyboard] update debounce time on kint boards (qmk#13351)
  [Keymap] RGB Timeout added to userspace (qmk#13339)
  [Keyboard][Bug] Fix LED indicators on Skeletn87 (qmk#13335)
  [Keyboard] Pteron36, open source 3x5_3 supporting layout (qmk#13313)
  Drashna's split updates (qmk#13350)
  [Keymap] Create bingocaller keymap for DZ60RGB-ANSI (qmk#13311)
  ...
@s-show s-show deleted the translation_keycodes_basic branch July 6, 2021 13:32
jakeprime pushed a commit to jakeprime/qmk_firmware that referenced this pull request Jul 10, 2021
* 'keycodes_basic.md' copied.

* Translation completed.

* update to "breakpoint_2021_05_29".

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* update based on comment.

* update based on comment.

Co-authored-by: shela <shelaf@users.noreply.github.com>
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Jul 11, 2021
* 'keycodes_basic.md' copied.

* Translation completed.

* update to "breakpoint_2021_05_29".

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* update based on comment.

* update based on comment.

Co-authored-by: shela <shelaf@users.noreply.github.com>
wox pushed a commit to wox/qmk_firmware that referenced this pull request Aug 14, 2021
* 'keycodes_basic.md' copied.

* Translation completed.

* update to "breakpoint_2021_05_29".

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* update based on comment.

* update based on comment.

Co-authored-by: shela <shelaf@users.noreply.github.com>
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
* 'keycodes_basic.md' copied.

* Translation completed.

* update to "breakpoint_2021_05_29".

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* update based on comment.

* update based on comment.

Co-authored-by: shela <shelaf@users.noreply.github.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* 'keycodes_basic.md' copied.

* Translation completed.

* update to "breakpoint_2021_05_29".

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* Update docs/ja/keycodes_basic.md

Co-authored-by: shela <shelaf@users.noreply.github.com>

* update based on comment.

* update based on comment.

Co-authored-by: shela <shelaf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants