Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float8 training: clean up recipe names #1730

Merged
merged 1 commit into from
Feb 19, 2025
Merged

float8 training: clean up recipe names #1730

merged 1 commit into from
Feb 19, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Feb 18, 2025

Summary:

Originally these recipe names were added with the intention of polishing
the API later. Later is now, this PR cleans up the names to make them
easier to understand.

Test Plan:

./test/float8/test_everything.sh

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Feb 18, 2025

Copy link

pytorch-bot bot commented Feb 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1730

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 8da2519 with merge base 988c5c9 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vkuzo added a commit that referenced this pull request Feb 18, 2025
Summary:

Originally these recipe names were added with the intention of polishing
the API later. Later is now, this PR cleans up the names to make them
easier to understand.

Test Plan:

```
./test/float8/test_everything.sh
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 3b94ff31a06b0ed554e4cdf764be424fd2d3a3cf
ghstack-comment-id: 2666973711
Pull Request resolved: #1730
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 18, 2025
@vkuzo vkuzo added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Feb 18, 2025
@HDCharles HDCharles self-requested a review February 18, 2025 22:39
@vkuzo vkuzo merged commit 7fc8ad4 into main Feb 19, 2025
45 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants