float8 training: make the "config from recipe" API polished #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1731
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Feb 18, 2025
Summary: This PR makes the API that takes a recipe name (enum or string) and returns a `Float8LinearConfig` instance more polished and ready for usage in README.md docs and by partner callsites such as torchtitan and torchtune. Test Plan: ``` ./test/float8/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4f72eeb19603d6e1203fa9bf6ce8235bf431ecad ghstack-comment-id: 2667010633 Pull Request resolved: #1731
facebook-github-bot
added
the
CLA Signed
drisspg
approved these changes
Feb 18, 2025
HDCharles
approved these changes
Feb 18, 2025
| class Float8LinearRecipeName(enum.Enum): | ||
| TENSORWISE = "tensorwise" | ||
| ROWWISE = "rowwise" | ||
| ROWWISE_WITH_GW_HP = "rowwise_with_gw_hp" |
There was a problem hiding this comment.
nit: wondering if gw_hp should be clarified somewhere as far as what it means?
it might also make sense to allow a fully written out version
vkuzo
added
the
topic: improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR makes the API that takes a recipe name (enum or string) and
returns a
Float8LinearConfiginstance more polished and ready forusage in README.md docs and by partner callsites such as torchtitan and
torchtune.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: