Add Context.set_tlsext_use_srtp #734

jlaine · 2018-02-06T10:07:04Z

This allows negotiating SRTP keying material, which is useful when using
DTLS-SRTP, as WebRTC does for example.

codecov · 2018-02-06T12:21:51Z

Codecov Report

Merging #734 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   97.05%   97.06%   +0.01%     
==========================================
  Files          18       18              
  Lines        5705     5726      +21     
  Branches      395      396       +1     
==========================================
+ Hits         5537     5558      +21     
  Misses        112      112              
  Partials       56       56

Impacted Files	Coverage Δ
src/OpenSSL/SSL.py	`94.97% <100%> (+0.05%)`	⬆️
tests/test_ssl.py	`99.13% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc15e8...fc2c661. Read the comment docs.

jlaine · 2018-02-10T21:34:57Z

I'm not sure what the best form would be for the "profiles" argument. Two possibilities:

A colon-delimited bytestring : this mimics the OpenSSL API exactly, and works the same as existing Context.set_cipher_list for example
A list of bytestrings : this feels somewhat more pythonic, but deviates from the OpenSSL API

Suggestions?

reaperhulk · 2018-02-13T14:37:13Z

I dislike the OpenSSL APIs for this, but pyOpenSSL generally doesn't abstract much away and since we already have an API that exposes colon delimited behavior it probably makes sense for this one to look like that as well.

One day we'll have a nice TLS API. pyOpenSSL won't be it...

jlaine · 2018-02-13T15:37:01Z

OK thanks for the feedback I'll write the corresponding API docs.

Quick question : any reason why we don't use sphinx.autodoc's automethod? It seems a shame to have to duplicate the docstrings everywhere.

hynek · 2018-02-13T16:54:43Z

We do for new code. Nobody wanted to spend their time to move everything to docstrings yet.

jlaine · 2018-02-13T18:24:19Z

Duly noted, I've updated my pull request to use automethod

jlaine · 2018-03-19T17:38:54Z

This requires #742

This allows negotiating SRTP keying material, which is useful when using DTLS-SRTP, as WebRTC does for example.

jlaine · 2018-03-27T15:24:34Z

@reaperhulk anything you'd like me to change with this PR?

reaperhulk · 2018-05-16T15:40:36Z

@jlaine could you rebase this?

reaperhulk · 2018-05-16T15:44:36Z

Actually I can resolve, nevermind :)

197: Scheduled weekly dependency update for week 20 r=mithrandi a=pyup-bot ### Update [hypothesis](https://pypi.org/project/hypothesis) from **3.56.5** to **3.57.0**. *The bot wasn't able to find a changelog for this release. [Got an idea?](/~https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/hypothesis - Repo: /~https://github.com/HypothesisWorks/hypothesis/issues </details> ### Update [pbr](https://pypi.org/project/pbr) from **4.0.2** to **4.0.3**. *The bot wasn't able to find a changelog for this release. [Got an idea?](/~https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pbr - Homepage: https://docs.openstack.org/pbr/latest/ </details> ### Update [pyopenssl](https://pypi.org/project/pyopenssl) from **17.5.0** to **18.0.0**. <details> <summary>Changelog</summary> ### 18.0.0 ``` ------------------- Backward-incompatible changes: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - The minimum ``cryptography`` version is now 2.2.1. - Support for Python 2.6 has been dropped. Deprecations: ^^^^^^^^^^^^^ *none* Changes: ^^^^^^^^ - Added ``Connection.get_certificate`` to retrieve the local certificate. `733 </~https://github.com/pyca/pyopenssl/pull/733>`_ - ``OpenSSL.SSL.Connection`` now sets ``SSL_MODE_AUTO_RETRY`` by default. `753 </~https://github.com/pyca/pyopenssl/pull/753>`_ - Added ``Context.set_tlsext_use_srtp`` to enable negotiation of SRTP keying material. `734 </~https://github.com/pyca/pyopenssl/pull/734>`_ ---- ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pyopenssl - Changelog: https://pyup.io/changelogs/pyopenssl/ - Homepage: https://pyopenssl.org/ - Docs: https://pythonhosted.org/pyOpenSSL/ </details>

134: Scheduled weekly dependency update for week 20 r=mithrandi a=pyup-bot ### Update [pyopenssl](https://pypi.org/project/pyopenssl) from **17.5.0** to **18.0.0**. <details> <summary>Changelog</summary> ### 18.0.0 ``` ------------------- Backward-incompatible changes: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - The minimum ``cryptography`` version is now 2.2.1. - Support for Python 2.6 has been dropped. Deprecations: ^^^^^^^^^^^^^ *none* Changes: ^^^^^^^^ - Added ``Connection.get_certificate`` to retrieve the local certificate. `733 </~https://github.com/pyca/pyopenssl/pull/733>`_ - ``OpenSSL.SSL.Connection`` now sets ``SSL_MODE_AUTO_RETRY`` by default. `753 </~https://github.com/pyca/pyopenssl/pull/753>`_ - Added ``Context.set_tlsext_use_srtp`` to enable negotiation of SRTP keying material. `734 </~https://github.com/pyca/pyopenssl/pull/734>`_ ---- ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pyopenssl - Changelog: https://pyup.io/changelogs/pyopenssl/ - Homepage: https://pyopenssl.org/ - Docs: https://pythonhosted.org/pyOpenSSL/ </details>

188: Scheduled weekly dependency update for week 21 r=mithrandi a=pyup-bot ### Update [pyasn1](https://pypi.org/project/pyasn1) from **0.4.2** to **0.4.3**. *The bot wasn't able to find a changelog for this release. [Got an idea?](/~https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pyasn1 - Changelog: https://pyup.io/changelogs/pyasn1/ - Repo: /~https://github.com/etingof/pyasn1 </details> ### Update [pyopenssl](https://pypi.org/project/pyopenssl) from **17.5.0** to **18.0.0**. <details> <summary>Changelog</summary> ### 18.0.0 ``` ------------------- Backward-incompatible changes: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ - The minimum ``cryptography`` version is now 2.2.1. - Support for Python 2.6 has been dropped. Deprecations: ^^^^^^^^^^^^^ *none* Changes: ^^^^^^^^ - Added ``Connection.get_certificate`` to retrieve the local certificate. `733 </~https://github.com/pyca/pyopenssl/pull/733>`_ - ``OpenSSL.SSL.Connection`` now sets ``SSL_MODE_AUTO_RETRY`` by default. `753 </~https://github.com/pyca/pyopenssl/pull/753>`_ - Added ``Context.set_tlsext_use_srtp`` to enable negotiation of SRTP keying material. `734 </~https://github.com/pyca/pyopenssl/pull/734>`_ ---- ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pyopenssl - Changelog: https://pyup.io/changelogs/pyopenssl/ - Homepage: https://pyopenssl.org/ - Docs: https://pythonhosted.org/pyOpenSSL/ </details> ### Update [python-dateutil](https://pypi.org/project/python-dateutil) from **2.7.2** to **2.7.3**. *The bot wasn't able to find a changelog for this release. [Got an idea?](/~https://github.com/pyupio/changelogs/issues/new)* <details> <summary>Links</summary> - PyPI: https://pypi.org/project/python-dateutil - Changelog: https://pyup.io/changelogs/python-dateutil/ - Docs: https://dateutil.readthedocs.io </details> Co-authored-by: pyup-bot <github-bot@pyup.io>

jlaine force-pushed the tlsext-srtp branch 2 times, most recently from 66e59c6 to e8b810e Compare February 6, 2018 12:21

jlaine force-pushed the tlsext-srtp branch from e8b810e to 152cbcd Compare February 13, 2018 15:46

jlaine force-pushed the tlsext-srtp branch from 152cbcd to 41e808c Compare February 13, 2018 18:10

alexwlchan mentioned this pull request Feb 13, 2018

Use autofocus for all module documentation/docstrings #737

Merged

jlaine force-pushed the tlsext-srtp branch 2 times, most recently from 77350e9 to bcd6ce9 Compare February 19, 2018 21:48

Add Context.set_tlsext_use_srtp

81c9ebd

This allows negotiating SRTP keying material, which is useful when using DTLS-SRTP, as WebRTC does for example.

jlaine force-pushed the tlsext-srtp branch from bcd6ce9 to 81c9ebd Compare March 21, 2018 13:52

Merge branch 'master' into tlsext-srtp

fc2c661

reaperhulk added this to the 18.0.0 milestone May 16, 2018

reaperhulk approved these changes May 16, 2018

View reviewed changes

reaperhulk merged commit 02261ad into pyca:master May 16, 2018

github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Context.set_tlsext_use_srtp #734

Add Context.set_tlsext_use_srtp #734

jlaine commented Feb 6, 2018

codecov bot commented Feb 6, 2018 •

edited

Loading

jlaine commented Feb 10, 2018

reaperhulk commented Feb 13, 2018

jlaine commented Feb 13, 2018

hynek commented Feb 13, 2018

jlaine commented Feb 13, 2018

jlaine commented Mar 19, 2018

jlaine commented Mar 27, 2018

reaperhulk commented May 16, 2018

reaperhulk commented May 16, 2018

Add Context.set_tlsext_use_srtp #734

Add Context.set_tlsext_use_srtp #734

Conversation

jlaine commented Feb 6, 2018

codecov bot commented Feb 6, 2018 • edited Loading

Codecov Report

jlaine commented Feb 10, 2018

reaperhulk commented Feb 13, 2018

jlaine commented Feb 13, 2018

hynek commented Feb 13, 2018

jlaine commented Feb 13, 2018

jlaine commented Mar 19, 2018

jlaine commented Mar 27, 2018

reaperhulk commented May 16, 2018

reaperhulk commented May 16, 2018

codecov bot commented Feb 6, 2018 •

edited

Loading