Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum cryptography version to 2.2.1, drop python 2.6 #742

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

jlaine
Copy link
Contributor

@jlaine jlaine commented Mar 19, 2018

No description provided.

@jlaine jlaine force-pushed the cryptography-2.2 branch from 13dd6ce to 59a453e Compare March 19, 2018 17:22
@codecov
Copy link

codecov bot commented Mar 19, 2018

Codecov Report

Merging #742 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
- Coverage   97.05%   97.05%   -0.01%     
==========================================
  Files          18       18              
  Lines        5712     5703       -9     
  Branches      395      395              
==========================================
- Hits         5544     5535       -9     
  Misses        112      112              
  Partials       56       56
Impacted Files Coverage Δ
src/OpenSSL/SSL.py 94.91% <100%> (-0.05%) ⬇️
tests/test_ssl.py 99.12% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993c4e4...ffb6cda. Read the comment docs.

setup.py Outdated
# pytest 3.3 doesn't support Python 2.6 anymore.
# Remove this pin once we drop Python 2.6 too.
"pytest>=3.0.1,<3.3.0",
"pytest",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the version minimum in the pin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done!

@jlaine jlaine force-pushed the cryptography-2.2 branch 2 times, most recently from 2b05be5 to 683881c Compare March 21, 2018 07:10
@jlaine jlaine force-pushed the cryptography-2.2 branch from 683881c to ffb6cda Compare March 21, 2018 07:14
@jlaine jlaine changed the title Raise minimum cryptography version to 2.2, drop python 2.6 Raise minimum cryptography version to 2.2.1, drop python 2.6 Mar 21, 2018
@alex alex merged commit 1ae7cb6 into pyca:master Mar 21, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants