Corrected regression with preference files name

[Vincent--]

Corrected a regression introduced by 351c8d5
(Default value of 50 was used for priority param when apt::setting is called inside pin.pp)
Added changes from #554

Signed-off-by: Vincent Deygas Vincent.Deygas@rewardgateway.com

[daenney]

@mhaskel I'm good with this but it would require a .minor release. It might very well be considered a regression but it changes the behaviour of the 2.x series up until now. This does make the upgrade path from 1.8 to 2.x better. What do you think?

[Vincent--]

One more thing to take into account : there is no priority related to the file name for apt-preference.
The priority is given inside the file with the Pin-Priority param

So if you keep a priority number in the file name, this might be misunderstood by users not familiar with apt-preference...

[underscorgan]

@daenney yeah, I think i'm ok with this (but also think having this in a minor release rather than a bugfix would be good).

[underscorgan]

Thanks @Vincent-- !