Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected regression with preference files name (since 2.0.0) #559

Closed
wants to merge 3 commits into from
Closed

Corrected regression with preference files name (since 2.0.0) #559

wants to merge 3 commits into from

Conversation

Vincent--
Copy link

Corrected a regression introduced by 351c8d5
(Default value of 50 was used for priority param when apt::setting is called inside pin.pp)

Added changes from #554

Corrected a regression with 351c8d5
(Default value of 50 was used for priority param when apt::setting is called inside pin.pp)
@Vincent-- Vincent-- changed the title Update setting.pp Corrected regression with preference file name (since 2.0.0) Aug 24, 2015
@Vincent-- Vincent-- changed the title Corrected regression with preference file name (since 2.0.0) Corrected regression with preference files name (since 2.0.0) Aug 24, 2015
@DavidS
Copy link

DavidS commented Sep 1, 2015

@mhaskel , @bmjen could you have a look at this?

@daenney
Copy link

daenney commented Sep 2, 2015

This needs a squash, 1 feature, 1 commit to keep the history reasonable.

@DavidS
Copy link

DavidS commented Sep 2, 2015

@daenney is the rest OK?

@Vincent--
Copy link
Author

See #562

@daenney
Copy link

daenney commented Sep 2, 2015

Apparently there's now two pull requests from @Vincent-- for (partially) the same issue. I'd appreciate if one would get closed or both cleanly separated.

@Vincent-- Vincent-- closed this Sep 2, 2015
@Vincent--
Copy link
Author

Hey @daenney,

You've asked for a squash, so I did...
See #562

@daenney
Copy link

daenney commented Sep 2, 2015

@Vincent-- Ah, thanks. I assumed you'd force-push it to this one, not raise a new PR. That's where my confusion came from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants