(FACT-2740) Add Gce fact #2035
(FACT-2740) Add Gce fact #2035
Conversation
| def call_the_resolver | ||
| bios_vendor = Facter::Resolvers::Linux::DmiBios.resolve(:bios_vendor) | ||
|
|
||
| fact_value = bios_vendor&.include?('Google') ? Facter::Resolvers::Gce.resolve(:metadata) : nil |
There was a problem hiding this comment.
this reads like it should be a general Unix fact
There was a problem hiding this comment.
And it is, because Linux is the root facts platform for Debian, Rhel and Sles flavors. This relation is exemplified in lib/facter/os_hierarchy.json. I know it's confusing with the way facts files are structured now, but we'll move all the common ones into the Linux facts folder.
There was a problem hiding this comment.
sorry, what i meant is: this looks like it would work the same for Solaris and FreeBSD, without a change
There was a problem hiding this comment.
I didn't add this fact on Solaris and FreeBSD because the virtual fact is not yet implemented on them. So, I'm not sure if it would work as it is.
There was a problem hiding this comment.
And also I want to add that the DmiBios fact for Linux doesn't work on Solaris.
|
CLA signed by all contributors. |
Filipovici-Andrei
force-pushed
the
FACT-2740
branch
from
f86e31b to
e67b104
Compare
Filipovici-Andrei
force-pushed
the
FACT-2740
branch
from
e67b104 to
bfd0b64
Compare
Added Gce fact for Windows and Linux platforms