(FACT-2721) Added Solaris virtual fact #2033
Conversation
sebastian-miclea
force-pushed
the
FACT-2721
branch
2 times, most recently
from
03adf43 to
19b89a1
Compare
lib/facter/facts/solaris/virtual.rb
Outdated
|
|
||
| return if zone_name == 'global' | ||
|
|
||
| zone_name |
There was a problem hiding this comment.
facter/lib/inc/facter/facts/vm.hpp
Line 139 in 4844068
There was a problem hiding this comment.
Updated, thanks!
lib/facter/facts/solaris/virtual.rb
Outdated
| def call_the_resolver | ||
| @log.debug('Solaris Virtual Resolver') | ||
|
|
||
| fact_value = check_ldom || check_zone || 'physical' |
There was a problem hiding this comment.
if ldom and zone fail to retrieve the fact this method is called =>
before stating that is physical.Method definition :
this is already implemented in linux/virtual (check_other_facts method)
There was a problem hiding this comment.
Updated, thanks!
sebastian-miclea
force-pushed
the
FACT-2721
branch
from
19b89a1 to
e46cba4
Compare
sebastian-miclea
changed the title
|
CLA signed by all contributors. |
| product_name = Facter::Resolvers::Solaris.const_get(klass).resolve(:product_name) | ||
| bios_vendor = Facter::Resolvers::Solaris.const_get(klass).resolve(:bios_vendor) | ||
|
|
||
| return 'kvm' if bios_vendor&.include?('Amazon EC2') |
There was a problem hiding this comment.
this looks like we're doing work that something else could do better, and more exhaustively
There was a problem hiding this comment.
I've updated the PR to also check if the hypervisor is Xen, If that doesn't return anything and bios_vendor is Amazon EC2, then by exclusion, it can only be KVM. If that also fails, it will check hypervisors mapped here by product_name.
sebastian-miclea
force-pushed
the
FACT-2721
branch
from
e46cba4 to
9a658e3
Compare
|
Jenkins please test this on solaris11-64a,solaris114-64a,solaris-11-sparca |
sebastian-miclea
force-pushed
the
FACT-2721
branch
from
9a658e3 to
5d7b20e
Compare
|
Jenkins please test this on solaris11-64a,solaris114-64a,solaris-11-sparca |
|
Jenkins please test this on solaris11-64a,solaris114-64a,solaris11-sparca |
|
Jenkins please test this on solaris11-64a,solaris114-64a,solaris11-SPARCa |
No description provided.