Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue ducasse example cleanup #577

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Rescue ducasse example cleanup #577

merged 6 commits into from
Aug 14, 2024

Conversation

tinchodias
Copy link
Collaborator

@Ducasse I recovered commits from your branch: /~https://github.com/pharo-graphics/Bloc/tree/2023-10--02-lessExamples

I had to resolve conflicts. And I avoided the commit on animations because I have changes on it.

If you agree, you merge this and delete the original branch

@tinchodias tinchodias requested a review from Ducasse August 10, 2024 01:10
@tinchodias
Copy link
Collaborator Author

:-/ my conflict-solving changes introduced a compilation error


*** Warning: Warning: The following definitions had errors while loading.  Press Proceed to try to load them again (they may work on a second pass):
  BlGeometryVisualAndLayoutBoundsTestOld

Syntax Error on line 4: 'End of statement expected'
===================================================
01: testAlignedIcon
02: 
03: 	| anIconElement aLabelElement aContainerElement |
04: 	anIconElement := self testEmptyIconElement geometry:
                  _^_
05: 		                 self testTrianglePolygon.
06: 	aLabelElement := self testTextElementWithRunText.
07: 	aContainerElement := self testIconAndTextContainer.
08: 	aContainerElement addChildren: {
09: 			anIconElement.
10: 			aLabelElement }.
11: 	^ aContainerElement
CodeError:RBSyntaxErrorNotice UndefinedObject>>#DoIt 84:End of statement expected->testAlignedIcon

@Ducasse
Copy link
Contributor

Ducasse commented Aug 10, 2024

Tx martin!

@Ducasse
Copy link
Contributor

Ducasse commented Aug 10, 2024

This is strange I do not get why we would have a syntax error

@tinchodias tinchodias merged commit 7aa3072 into dev Aug 14, 2024
12 checks passed
@tinchodias tinchodias deleted the RescueDucasseExampleCleanup branch August 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants