-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paper_trail.update_columns is setting an incorrect Version#created_at value #1395
Closed
3 tasks done
Labels
Comments
iiwo
added a commit
to iiwo/paper_trail
that referenced
this issue
Aug 1, 2022
* `paper_trail.update_columns` was previously setting `version.created_at` as the `recod.updated_at` value. * Since `update_columns` does not update timestamps - the previous update date was being used for the `version.created_at` instead of the actual update date. * This change removes the `created_at` value from the data hash, casuing the default AR generated timestamp to be used instead for the `version.created_at` Fixes paper-trail-gem#1395
iiwo
added a commit
to iiwo/paper_trail
that referenced
this issue
Aug 1, 2022
Use the default(AR generated) timestamp to the `version.created_at` when using `paper_trail.update_columns.` `paper_trail.update_columns` was previously setting `version.created_at` as the `recod.updated_at` value. Since `update_columns` does not update timestamps - the previous update date was being used for the `version.created_at` instead of the actual update date. Fixes paper-trail-gem#1395
iiwo
added a commit
to iiwo/paper_trail
that referenced
this issue
Aug 1, 2022
Use the default(AR generated) timestamp to the `version.created_at` when using `paper_trail.update_columns.` `paper_trail.update_columns` was previously setting `version.created_at` as the `recod.updated_at` value. Since `update_columns` does not update timestamps - the previous update date was being used for the `version.created_at` instead of the actual update date. Fixes paper-trail-gem#1395
iiwo
added a commit
to iiwo/paper_trail
that referenced
this issue
Aug 1, 2022
Use the default(AR generated) timestamp for the `Version#created_at` velue when using `PaperTrail::RecordTrail#update_columns`. `PaperTrail::RecordTrail#update_columns` was previously setting `Version#created_at` as the recod `updated_at` value. Since `update_columns` does not update timestamps - the previous update date was being used for the `Version#created_at` instead of the actual update date. Fixes paper-trail-gem#1395
6 tasks
iiwo
added a commit
to iiwo/paper_trail
that referenced
this issue
Aug 1, 2022
Use the default(AR generated) timestamp for the `Version#created_at` value when using `PaperTrail::RecordTrail#update_columns`. `PaperTrail::RecordTrail#update_columns` was previously setting `Version#created_at` as the recod `updated_at` value. Since `update_columns` does not update timestamps - the previous update date was being used for the `Version#created_at` instead of the actual update date. Fixes paper-trail-gem#1395
iiwo
added a commit
to iiwo/paper_trail
that referenced
this issue
Aug 1, 2022
Use the default(AR generated) timestamp for the `Version#created_at` value when using `PaperTrail::RecordTrail#update_columns`. `PaperTrail::RecordTrail#update_columns` was previously setting `Version#created_at` as the recod `updated_at` value. Since `update_columns` does not update timestamps - the previous update date was being used for the `Version#created_at` instead of the actual update date. Fixes paper-trail-gem#1395
This issue has been automatically marked as stale due to inactivity. |
jaredbeck
pushed a commit
that referenced
this issue
Nov 12, 2022
Use the default(AR generated) timestamp for the `Version#created_at` value when using `PaperTrail::RecordTrail#update_columns`. `PaperTrail::RecordTrail#update_columns` was previously setting `Version#created_at` as the recod `updated_at` value. Since `update_columns` does not update timestamps - the previous update date was being used for the `Version#created_at` instead of the actual update date. Fixes #1395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PaperTrail::RecordTrail#update_columns
is settingVersion#created_at
as therecod.updated_at
value.update_columns
does not update timestamps - the previous update date is used for theVersion#created_at
instead of the actual update date (current)I think this was actually addressed in the original PR, but the adjustment that fixed the value got removed during the code review
paper_trail
gemThe text was updated successfully, but these errors were encountered: