Fix invalid version created_at value when using update_columns #1396
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iiwo
force-pushed
the
bug/update_columns_created_at
branch
from
571e165 to
399de21
Compare
Use the default(AR generated) timestamp for the `Version#created_at` value when using `PaperTrail::RecordTrail#update_columns`. `PaperTrail::RecordTrail#update_columns` was previously setting `Version#created_at` as the recod `updated_at` value. Since `update_columns` does not update timestamps - the previous update date was being used for the `Version#created_at` instead of the actual update date. Fixes paper-trail-gem#1395
iiwo
force-pushed
the
bug/update_columns_created_at
branch
from
399de21 to
7af51bd
Compare
|
Thanks for your P.R @iiwo . SGTM. I think we can merge. Do you see any problems @jaredbeck ? |
jaredbeck
reviewed
Aug 16, 2022
|
Merged in #1405, preserving your authorship. Thanks @iiwo for the fix, and thanks @gurgelrenan for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the default(AR generated) timestamp for the
Version#created_atvalue when usingPaperTrail::RecordTrail#update_columns.PaperTrail::RecordTrail#update_columnswas previously settingVersion#created_atas the recodupdated_atvalue.Since
update_columnsdoes not update timestamps - the previous update date was being used for theVersion#created_atinstead of the actual update date.Fixes #1395
master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.