Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IP-145] New table for users with failed user_data_processing #138

Merged
merged 17 commits into from
May 10, 2021

Conversation

michaeldisaro
Copy link
Contributor

@michaeldisaro michaeldisaro commented Apr 27, 2021

List of Changes

  • Modified UserDataProcessingTrigger function to process also documents in FAILED and CLOSED status
  • FAILED status implies a new record insertion into FailedUserDataProcessing with 'choice' as PK and 'fiscalCode' as RK
  • CLOSED status implies a deletion from FailedUserDataProcessing for 'choice' as PK and 'fiscalCode' as RK
  • Added GetFailedUserDataProcessingList function to get all failed requests by choice

Motivation and Context

We want to have a storage table that informs us about users that have a user_data_processing request remained in a FAILED status to be able to launch a recovery and mitigation.

How Has This Been Tested?

It has been tested by performing:

  • yarn install --frozen-lockfile
  • yarn build
  • yarn lint
  • yarn test

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@michaeldisaro michaeldisaro requested a review from balanza April 27, 2021 16:15
@michaeldisaro
Copy link
Contributor Author

@balanza this is the first step, inserting and removing records from a storage table. I had to create the table manually. Is there any trick to have it automatically created if not existing?

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

@michaeldisaro michaeldisaro marked this pull request as ready for review May 6, 2021 14:14
UserDataProcessingTrigger/utils.ts Outdated Show resolved Hide resolved
UserDataProcessingTrigger/utils.ts Outdated Show resolved Hide resolved
@michaeldisaro michaeldisaro requested a review from balanza May 6, 2021 17:31
utils/storage.ts Outdated Show resolved Hide resolved
UserDataProcessingTrigger/index.ts Outdated Show resolved Hide resolved
Michael Disaro added 2 commits May 7, 2021 08:51
@michaeldisaro michaeldisaro merged commit 28d6f91 into master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants