[#IP-145] New table for users with failed user_data_processing

UserDataProcessingTrigger/handler.ts

@@ -19,12 +19,12 @@ import {
 } from "../utils/appinsightsEvents";
 import { flags } from "../utils/featureFlags";
 import { isOrchestratorRunning } from "../utils/orchestrator";
-import { InsertTableEntityType, DeleteTableEntityType } from "./utils";
+import { DeleteTableEntity, InsertTableEntity } from "../utils/storage";
 
 const eg = TableUtilities.entityGenerator;
 
 // configure log prefix
-const logPrefix = "UserDataProcessingTrigger";
+const logPrefix = "UserDataProcessingHandler";
 
 // models the subset of UserDataProcessing documents that this orchestrator accepts
 export type ProcessableUserDataDownload = t.TypeOf<
@@ -174,7 +174,7 @@ const raiseAbortEventOnOrchestrator = (
 const processFailedUserDataProcessing = async (
   context: Context,
   processable: FailedUserDataProcessing,
-  insertEntityFn: InsertTableEntityType
+  insertEntityFn: InsertTableEntity
 ): Promise<void> => {
   // If a failed user_data_processing has been inserted
   // we insert a record into failed_user_data_processing table storage
@@ -194,7 +194,7 @@ const processFailedUserDataProcessing = async (
 const processClosedUserDataProcessing = async (
   context: Context,
   processable: ClosedUserDataProcessing,
-  deleteEntityFn: DeleteTableEntityType
+  deleteEntityFn: DeleteTableEntity
 ): Promise<void> => {
   // If a completed user_data_processing has been inserted
   // we delete any record into failed_user_data_processing table storage
@@ -213,8 +213,8 @@ const processClosedUserDataProcessing = async (
 
 // eslint-disable-next-line prefer-arrow/prefer-arrow-functions, sonarjs/cognitive-complexity
 export const triggerHandler = (
-  addFailure: InsertTableEntityType,
-  removeFailure: DeleteTableEntityType
+  addFailure: InsertTableEntity,
+  removeFailure: DeleteTableEntity
 ) => (
   context: Context,
   input: unknown // eslint-disable-next-line sonarjs/cognitive-complexity

UserDataProcessingTrigger/index.ts

@@ -1,20 +1,38 @@
 import { Context } from "@azure/functions";
-import { triggerHandler } from "./handler";
+import { createTableService } from "azure-storage";
+import { getConfigOrThrow } from "../utils/config";
 import {
-  addFailedUserDataProcessing,
-  removeFailedUserDataProcessing,
-  createFailedUserDataProcessingTableIfNotExists
-} from "./utils";
+  createTableIfNotExists,
+  deleteTableEntity,
+  insertTableEntity
+} from "../utils/storage";
+import { triggerHandler } from "./handler";
 
-createFailedUserDataProcessingTableIfNotExists();
+// configure log prefix
+const logPrefix = "UserDataProcessingTrigger";
 
-export const index = (
+// prepare table storage utils
+const config = getConfigOrThrow();
+const connectionString = config.FailedUserDataProcessingStorageConnection;
+const failedUserDataProcessingTable = config.FAILED_USER_DATA_PROCESSING_TABLE;
+const tableService = createTableService(connectionString);
+
+export const index = async (
   context: Context,
   input: unknown
 ): Promise<ReadonlyArray<string | void>> => {
+  (await createTableIfNotExists(
+    tableService,
+    failedUserDataProcessingTable
+  )).mapLeft(_ => {
+    context.log.verbose(
+      `${logPrefix}|Failed to create storage table ${failedUserDataProcessingTable}`
+    );
+  });
+
   const handler = triggerHandler(
-    addFailedUserDataProcessing,
-    removeFailedUserDataProcessing
+    insertTableEntity(tableService, failedUserDataProcessingTable),
+    deleteTableEntity(tableService, failedUserDataProcessingTable)
   );
   return handler(context, input);
 };

utils/storage.ts

@@ -5,6 +5,19 @@ import { none, Option, some } from "fp-ts/lib/Option";
 
 import { ITuple2, Tuple2 } from "italia-ts-commons/lib/tuples";
 
+/**
+ * A promisified version of TableService.createTableIfNotExists
+ */
+export const createTableIfNotExists = (
+  tableService: TableService,
+  table: string
+): Promise<Either<Error, TableService.TableResult>> =>
+  new Promise(resolve =>
+    tableService.createTableIfNotExists(table, (error, result, response) =>
+      resolve(response.isSuccessful ? right(result) : left(error))
+    )
+  );
+
 /**
  * A promisified version of TableService.insertEntity
  */
@@ -33,6 +46,8 @@ export const insertTableEntity = (
     )
   );
 
+export type InsertTableEntity = ReturnType<typeof insertTableEntity>;
+
 /**
  * A promisified version of TableService.deleteEntity
  */
@@ -54,3 +69,5 @@ export const deleteTableEntity = (
         )
     )
   );
+
+export type DeleteTableEntity = ReturnType<typeof deleteTableEntity>;