Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update header logo defaults #580

Closed
BSFishy opened this issue Mar 9, 2023 · 6 comments
Closed

Update header logo defaults #580

BSFishy opened this issue Mar 9, 2023 · 6 comments
Assignees
@andreymyssak
Labels
good first issue Good for newcomers refactor

Comments

@BSFishy
Copy link
Contributor

BSFishy commented Mar 9, 2023

Header logo still has defaults that refer to Elastic. These should be changed to their OpenSearch counterparts:

oui/src/components/header/header_logo.tsx

Lines 57 to 58 in e7dc71d

iconType = 'logoElastic',
iconTitle = 'Elastic',

@BSFishy BSFishy added good first issue Good for newcomers refactor labels Mar 9, 2023
@KrooshalUX
Copy link
Contributor

This might be a dupe of work tracked either here #110 or here #113

Finishing #113 unblocks #110 , btw

@BSFishy
Copy link
Contributor Author

BSFishy commented Mar 9, 2023

This might be a dupe of work tracked either here #110 or here #113

Finishing #113 unblocks #110 , btw

I don't think this relates to any of that work, this is specifically about the defaults for the OuiHeaderLogo component being outdated.

@andreymyssak
Copy link
Collaborator

@BSFishy I'd like to work on this, do you mind if I replace it in all the icons that use logoElastic/Elastic?

@BSFishy
Copy link
Contributor Author

BSFishy commented Mar 21, 2023

@BSFishy I'd like to work on this, do you mind if I replace it in all the icons that use logoElastic/Elastic?

Sounds good. This issue is for specifically changing those 2 lines in oui/src/components/header/header_logo.tsx. If there is some other work you think should be done, feel free to open a new issue where it can be discussed further

andreymyssak added a commit to andreymyssak/oui that referenced this issue Mar 23, 2023
@andreymyssak @SergeyMyssak
Update header logo defaults (opensearch-project#580)
7a3eec0 
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
@andreymyssak andreymyssak mentioned this issue Mar 23, 2023
Merged
6 tasks
@KrooshalUX KrooshalUX mentioned this issue Mar 23, 2023
Closed
BSFishy pushed a commit that referenced this issue Mar 28, 2023
@andreymyssak @SergeyMyssak @seanneumann
Update header logo defaults (#580) (#621)
09a88d4 
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Apr 18, 2023
@github-actions @SergeyMyssak @seanneumann
Update header logo defaults (#580) (#621)
d16f18f 
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
(cherry picked from commit 09a88d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ashwin-pc
Copy link
Member

@andreymyssak this issue can be closed now right?

@andreymyssak
Copy link
Collaborator

@andreymyssak this issue can be closed now right?

@ashwin-pc yes, please close this issue

@BSFishy BSFishy closed this as completed Apr 25, 2023
SergeyMyssak added a commit to SergeyMyssak/oui that referenced this issue May 10, 2023
@andreymyssak @SergeyMyssak @seanneumann
Update header logo defaults (opensearch-project#580) (opensearch-proj…
f5cd73a 
…ect#621)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
SergeyMyssak added a commit to SergeyMyssak/oui that referenced this issue May 10, 2023
@SergeyMyssak
Revert "Update header logo defaults (opensearch-project#580) (opensea…
d559491 
…rch-project#621)"

This reverts commit f5cd73a.
SergeyMyssak added a commit to SergeyMyssak/oui that referenced this issue May 16, 2023
@SergeyMyssak
Revert "Update header logo defaults (opensearch-project#580) (opensea…
a76011a 
…rch-project#621)"

This reverts commit f5cd73a.

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
@seanneumann seanneumann moved this to Done in Look & Feel May 19, 2023
ashwin-pc pushed a commit that referenced this issue May 25, 2023
@opensearch-trigger-bot @github-actions
@SergeyMyssak @seanneumann
Update header logo defaults (#580) (#621) (#722)
7fc4f17 
(cherry picked from commit 09a88d4)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreymyssak andreymyssak

Labels
good first issue Good for newcomers refactor
Projects
Look & Feel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BSFishy @ashwin-pc @andreymyssak @KrooshalUX