Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Update header logo defaults #621

Merged

Conversation

andreymyssak
Copy link
Collaborator

Description

Update header logo defaults

Issues Resolved

#580

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
@andreymyssak andreymyssak requested a review from a team as a code owner March 23, 2023 13:46
@andreymyssak andreymyssak changed the title Update header logo defaults (#580) [CCI] Update header logo defaults Mar 23, 2023
@joshuarrrr
Copy link
Member

@andreymyssak For changes like this, do you mind also providing a screenshot in the PR description that shows the visual change? It makes it quicker to assess and approve.

@joshuarrrr joshuarrrr added the CCI College Contributor Initiative label Mar 23, 2023
@BSFishy BSFishy merged commit 09a88d4 into opensearch-project:main Mar 28, 2023
@BSFishy
Copy link
Contributor

BSFishy commented Apr 6, 2023

I believe changing defaults is breaking. Ping me if this should be backported.

@ashwin-pc
Copy link
Member

@BSFishy i dont think so, its not a public api so this should be fine to backport. Also based on the comments form #676 its breaking our deprecation backport too.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2023
Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
(cherry picked from commit 09a88d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SergeyMyssak added a commit to SergeyMyssak/oui that referenced this pull request May 10, 2023
…ect#621)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
SergeyMyssak added a commit to SergeyMyssak/oui that referenced this pull request May 10, 2023
SergeyMyssak added a commit to SergeyMyssak/oui that referenced this pull request May 16, 2023
…rch-project#621)"

This reverts commit f5cd73a.

Signed-off-by: Sergey Myssak <sergey.myssak@gmail.com>
ashwin-pc pushed a commit that referenced this pull request May 25, 2023
(cherry picked from commit 09a88d4)

Signed-off-by: Andrey Myssak <andreymyssak@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sergey Myssak <sergey.myssak@gmail.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x CCI College Contributor Initiative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants