Remove unnecessary ariane_soc_pkg dependency #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*_slv_t types are needed only in ariane_testharness. The CVA6 core should not depend on packages related to the SoC where it is placed. Signed-off-by: Luca Zulberti <zulberti.luca@gmail.com>
LucaZulberti
force-pushed
the
fix-ariane-pkg-dependencies
branch
from
25af484 to
bff4c9d
Compare
|
Thanks, @LucaZulberti, that LGTM. @MikeOpenHWGroup Can you confirm that this solves the dependency issue? If so, let's bring this in before #602. |
|
I can confirm that this resolves, the dependency issue, so yes, please merge this in ahead of #602. Thanks @LucaZulberti. |
zarubaf
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
Thanks @LucaZulberti, that looks fantastic to me. I've also tried building the FPGA which works. So I am going ahead with merging.
OttG
pushed a commit
to OttG/cva6
that referenced
this pull request
Jul 6, 2021
*_slv_t types are needed only in ariane_testharness. The CVA6 core should not depend on packages related to the SoC where it is placed. Signed-off-by: Luca Zulberti <zulberti.luca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With my work, I had the necessity to remove the dependency of ariane_soc package from the CVA6 core.
It was straightforward because *_slv_t types are needed only in ariane_testharness.
I'm not familiar with your build system (Bender, etc..) and I'm not sure this is the best solution to be maintained.
If you are interested in isolating better the code of CVA6 from the SoC where it is instantiated, this patch aims to obtain this result.
Draft until interested and improved.