Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oh-repeater: Fix key property does not refresh repeater #1919

Merged
merged 1 commit into from
Jun 13, 2023
Merged

oh-repeater: Fix key property does not refresh repeater #1919

merged 1 commit into from
Jun 13, 2023

Conversation

florian-h05
Copy link
Contributor

Fixes #1918.
Regression from #1904.

@florian-h05
oh-repeater: Fix key property does not refresh repeater
c198e8e 
Fixes openhab#1918.
Regression from openhab#1904.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added this to the 4.0 milestone Jun 8, 2023
@florian-h05 florian-h05 requested a review from a team as a code owner June 8, 2023 09:32
@relativeci
Copy link

relativeci bot commented Jun 8, 2023

Job #1024: Bundle Size — 15.77MiB (-0.32%).

b4e3e35(current) vs 067d7b5 main#1023(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (5 changes)
                 Current
Job #1024		      Baseline
Job #1023
Initial JS 1.73MiB(~-0.01%) 1.73MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.96% 93.97%
Chunks 219 219
Assets 689 689
Modules 1720(-0.41%) 1727
Duplicate Modules 85(-3.41%) 88
Duplicate Code 1.72%(-10.42%) 1.92%
Packages 138 138
Duplicate Packages 15 15
Total size by type (3 changes)
                 Current
Job #1024		      Baseline
Job #1023
CSS 858.62KiB (-0.08%) 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.26MiB (-0.37%) 9.29MiB
Media 295.6KiB 295.6KiB
Other 4.73MiB (-0.33%) 4.75MiB

View job #1024 report View main branch activity

@florian-h05
Copy link
Contributor Author

@ghys Can you please have a look at this PR? This regression broke some widgets …

ghys
ghys approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ghys ghys merged commit b6393c2 into openhab:main Jun 13, 2023
@florian-h05 florian-h05 deleted the oh-repeater-regression-1918 branch June 13, 2023 09:23
@florian-h05 florian-h05 mentioned this pull request Jun 13, 2023
Merged
@JustinGeorgi JustinGeorgi mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
main ui Main UI regression
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Vue key property does not refresh oh-repeater
2 participants
@florian-h05 @ghys