Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oh-repeater: Fix new data requested when css visibility changed #1904

Merged
merged 1 commit into from
May 22, 2023
Merged

oh-repeater: Fix new data requested when css visibility changed #1904

merged 1 commit into from
May 22, 2023

Conversation

florian-h05
Copy link
Contributor

Fixes #1804.

The oh-repeater re-requested it's data on every CSS visibility change because the data was asyncComputed. This makes the data load when the component is created and then stores it.

@florian-h05
oh-repeater: Fix new data requested when css visibility changed
b763fb2 
Fixes openhab#1804.

The oh-repeater re-requested it's data on every CSS visibility change because the data was asyncComputed.
This makes the data load when the component is created and then stores it.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels May 22, 2023
@florian-h05 florian-h05 added this to the 4.0 milestone May 22, 2023
@florian-h05 florian-h05 requested a review from a team as a code owner May 22, 2023 15:22
@relativeci
Copy link

relativeci bot commented May 22, 2023

Job #1011: Bundle Size — 15.77MiB (~+0.01%).

e221718(current) vs 009a111 main#1010(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1011		      Baseline
Job #1010
Initial JS 1.73MiB(+0.02%) 1.73MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.95% 93.95%
Chunks 219 219
Assets 689 689
Modules 1720 1720
Duplicate Modules 85 85
Duplicate Code 1.72% 1.72%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1011		      Baseline
Job #1010
CSS 858.62KiB 858.62KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.26MiB (~-0.01%) 9.26MiB
Media 295.6KiB 295.6KiB
Other 4.73MiB (+0.01%) 4.73MiB

View job #1011 report View main branch activity

ghys
ghys approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this makes sense, thanks.

@ghys ghys merged commit 63c122d into openhab:main May 22, 2023
@florian-h05 florian-h05 deleted the repeater-fix-1804 branch May 22, 2023 18:45
@hmerk
Copy link

hmerk commented May 22, 2023

Thanks @florian-h05 and @ghys for the quick review and merge!
Will check this soon for the main_widget project.

@JustinGeorgi JustinGeorgi mentioned this pull request Jun 8, 2023
Closed
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Jun 8, 2023
@florian-h05
oh-repeater: Fix key property does not refresh repeater
c198e8e 
Fixes openhab#1918.
Regression from openhab#1904.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this pull request Jun 8, 2023
Merged
ghys pushed a commit that referenced this pull request Jun 13, 2023
@florian-h05
oh-repeater: Fix key property does not refresh repeater (#1919)
b6393c2 
Fixes #1918.
Regression from #1904.

-- 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@JustinGeorgi JustinGeorgi mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys ghys approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

oh-repeater requests new data in the context of css visibility
3 participants
@florian-h05 @hmerk @ghys