Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant modifiers from interfaces #1847

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Remove redundant modifiers from interfaces #1847

merged 1 commit into from
Apr 20, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Apr 18, 2023

This removes redundant modifiers from the interfaces similar to openhab/openhab-core#3560.

@wborn wborn requested review from peuter and a team as code owners April 18, 2023 07:22
@wborn
Remove redundant modifiers from interfaces
35c4ea1 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the redundant-modifiers branch from 6c93c92 to 35c4ea1 Compare April 20, 2023 11:48
kaikreuzer
kaikreuzer approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 0fd9b15 into openhab:main Apr 20, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone Apr 20, 2023
@wborn wborn deleted the redundant-modifiers branch April 20, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@peuter peuter Awaiting requested review from peuter peuter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @kaikreuzer