Remove redundant public and abstract modifiers from interfaces #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer
reviewed
Apr 16, 2023
| @@ -30,5 +30,5 @@ public interface TimeBasedConditionHandler extends ConditionHandler { | |||
| * @param time The time to check. | |||
| * @return <code>true</code> if and only if the given time satisfies this condition. | |||
| */ | |||
| public abstract boolean isSatisfiedAt(ZonedDateTime time); | |||
| abstract boolean isSatisfiedAt(ZonedDateTime time); | |||
There was a problem hiding this comment.
Could the abstract keyword be removed as well by the script?
There was a problem hiding this comment.
Yes it worked, though I had to make one manual correction. See the new commit.
Signed-off-by: Wouter Born <github@maindrain.net>
wborn
changed the title
This was referenced Apr 18, 2023
kaikreuzer
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Apr 20, 2023
This removes redundant modifiers from the interfaces similar to openhab/openhab-core#3560. Signed-off-by: Wouter Born <github@maindrain.net>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a small script to remove redundant public modifiers from the interfaces (#3522 (comment)). WDYT?