Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed varianceSince and deviationSince #2036

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

mhilbush
Copy link
Contributor

Fixed varianceSince and deviationSince, which always returned null. Also enabled tests for varianceSince and deviationSince, which were not being executed (and therefore masking that those functions didn't work).

Signed-off-by: Mark Hilbush mark@hilbush.com

Signed-off-by: Mark Hilbush <mark@hilbush.com>
@mhilbush mhilbush requested a review from a team as a code owner December 30, 2020 21:02
@cweitkamp cweitkamp added bug An unexpected problem or unintended behavior of the Core persistence labels Dec 30, 2020
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added this to the 3.1 milestone Dec 30, 2020
@cweitkamp cweitkamp merged commit 890e767 into openhab:master Dec 30, 2020
@mhilbush mhilbush deleted the fix-varianceSince branch December 30, 2020 22:14
@cweitkamp cweitkamp added the patch A PR that has been cherry-picked to a patch release branch label Jan 10, 2021
cweitkamp pushed a commit that referenced this pull request Jan 10, 2021
Signed-off-by: Mark Hilbush <mark@hilbush.com>
@kaikreuzer kaikreuzer changed the title [Persistence Extensions] Fixed varianceSince and deviationSince Fixed varianceSince and deviationSince Jan 16, 2021
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 11, 2023
Signed-off-by: Mark Hilbush <mark@hilbush.com>
GitOrigin-RevId: 890e767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch persistence
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants