[persistence] Fix varianceSince and deviationSince (#2036)

Signed-off-by: Mark Hilbush <mark@hilbush.com>
openhab · Jan 10, 2021 · 321c443 · 321c443
1 parent 1cadfcf
commit 321c443
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/...sistence/src/main/java/org/openhab/core/persistence/extensions/PersistenceExtensions.java b/...sistence/src/main/java/org/openhab/core/persistence/extensions/PersistenceExtensions.java
@@ -397,6 +397,7 @@ public static DecimalType varianceSince(Item item, ZonedDateTime timestamp, Stri
             BigDecimal average = averageSince.toBigDecimal(), sum = BigDecimal.ZERO;
             int count = 0;
 
+            it = result.iterator();
             while (it.hasNext()) {
                 HistoricItem historicItem = it.next();
                 DecimalType value = historicItem.getState().as(DecimalType.class);

diff --git a/...ence/src/test/java/org/openhab/core/persistence/extensions/PersistenceExtensionsTest.java b/...ence/src/test/java/org/openhab/core/persistence/extensions/PersistenceExtensionsTest.java
@@ -236,6 +236,7 @@ public void testMinimumSwitchSince() {
         assertEquals(OnOffType.ON, historicItem.getState());
     }
 
+    @Test
     public void testVarianceSince() {
         numberItem.setState(new DecimalType(3025));
 
@@ -262,6 +263,7 @@ public void testVarianceSince() {
         assertNull(variance);
     }
 
+    @Test
     public void testDeviationSince() {
         numberItem.setState(new DecimalType(3025));