schema: actually add the schema file #32
Conversation
| "$ref": "defs-image.json#/definitions/manifestObject" | ||
| } | ||
| }, | ||
| "annotations": { |
There was a problem hiding this comment.
Is this part of the specification, yet?
There was a problem hiding this comment.
oh oops. That is yank-and-paste cruft I was mulling on.
On Fri, Apr 15, 2016 at 2:50 PM Stephen Day notifications@github.com
wrote:
In schema/manifest-list-schema.json
#32 (comment)
:
- "schemaVersion": {
"description": "This field specifies the image manifest-list schema version as an integer","id": "https://opencontainers.org/schema/image/manifest-list/schemaVersion","type": "integer"- },
- "mediaType": {
"id": "https://opencontainers.org/schema/image/manifest-list/mediaType","$ref": "defs-image.json#/definitions/mediaType"- },
- "manifests": {
"type": "array","items": {"$ref": "defs-image.json#/definitions/manifestObject"}- },
- "annotations": {
Is this part of the specification, yet?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
/~https://github.com/opencontainers/image-spec/pull/32/files/a5632104014382df2fc80ac79f88c26e0b286a4a#r59946235
There was a problem hiding this comment.
updated, and added a commit to remove it from the image manifest schema for
the time being.
On Fri, Apr 15, 2016 at 3:01 PM Vincent Batts vbatts@hashbangbash.com
wrote:
oh oops. That is yank-and-paste cruft I was mulling on.
On Fri, Apr 15, 2016 at 2:50 PM Stephen Day notifications@github.com
wrote:In schema/manifest-list-schema.json
#32 (comment)
:
- "schemaVersion": {
"description": "This field specifies the image manifest-list schema version as an integer","id": "https://opencontainers.org/schema/image/manifest-list/schemaVersion","type": "integer"- },
- "mediaType": {
"id": "https://opencontainers.org/schema/image/manifest-list/mediaType","$ref": "defs-image.json#/definitions/mediaType"- },
- "manifests": {
"type": "array","items": {"$ref": "defs-image.json#/definitions/manifestObject"}- },
- "annotations": {
Is this part of the specification, yet?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
/~https://github.com/opencontainers/image-spec/pull/32/files/a5632104014382df2fc80ac79f88c26e0b286a4a#r59946235
I managed to forget adding the file in opencontainers#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
This was yank-and-paste from the runtime-spec that I was mulling on and forgot to remove before the PR. While this might can be added back, it will likely have its own discussion. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
vbatts
force-pushed
the
schema_add_manifest_list
branch
from
a563210 to
4b14700
Compare
|
LGTM |
I managed to forget adding the file in
#18
Signed-off-by: Vincent Batts vbatts@hashbangbash.com