Json schema for image manifest and manifest list #18
Conversation
From opencontainers/runtime-spec@cdcabde Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Here is a validating schema for the Image Manifest /~https://github.com/opencontainers/image-spec/blob/master/manifest.md#image-manifest Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
/~https://github.com/opencontainers/image-spec/blob/master/manifest.md#manifest-list Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
On Tue, Apr 12, 2016 at 11:45:14AM -0700, Vincent Batts wrote:
While it's nice to have local copies of this sort of thing for offline should work fine, although it's probably nicer if we just host these |
|
I mulled on that too. This is a first step. |
|
LGTM, can you file issues for steps after this? |
| "type": "string", | ||
| "pattern": "^[a-z0-9]+:[a-fA-F0-9]+$" | ||
| }, | ||
| "blobObject": { |
There was a problem hiding this comment.
This is actually called a "Descriptor".
There was a problem hiding this comment.
where is that defined?
On Fri, Apr 15, 2016 at 1:07 PM Stephen Day notifications@github.com
wrote:
In schema/defs-image.json
#18 (comment)
:@@ -0,0 +1,99 @@
+{
- "description": "Definitions particular to OpenContainer Image Specification",
- "definitions": {
- "mediaType": {
"id": "https://opencontainers.org/schema/image/mediaType","type": "string","pattern": "^[a-z]+/[0-9a-zA-Z.+]+$"- },
- "digest": {
"description": "the cryptographic checksum digest of the object, in the pattern '<hash>:<hexadecimal digest>'","type": "string","pattern": "^[a-z0-9]+:[a-fA-F0-9]+$"- },
- "blobObject": {
This is actually called a "Descriptor".
—
You are receiving this because you modified the open/close state.Reply to this email directly or view it on GitHub
/~https://github.com/opencontainers/image-spec/pull/18/files/64b5003c9985ba8714201f1ecc01460770ab5828#r59933563
There was a problem hiding this comment.
This is what we have called it from the start. The godoc is here. I am not sure how it never made into this specification.
Other types with further fields, such as the manifest descriptor, are extensions to the descriptor type.
There was a problem hiding this comment.
ah fine. A name of a struct. Feel free to open a PR to include this in the
spec. I can update it here.
On Fri, Apr 15, 2016 at 1:27 PM Stephen Day notifications@github.com
wrote:
In schema/defs-image.json
#18 (comment)
:@@ -0,0 +1,99 @@
+{
- "description": "Definitions particular to OpenContainer Image Specification",
- "definitions": {
- "mediaType": {
"id": "https://opencontainers.org/schema/image/mediaType","type": "string","pattern": "^[a-z]+/[0-9a-zA-Z.+]+$"- },
- "digest": {
"description": "the cryptographic checksum digest of the object, in the pattern '<hash>:<hexadecimal digest>'","type": "string","pattern": "^[a-z0-9]+:[a-fA-F0-9]+$"- },
- "blobObject": {
This is what we have called it from the start. The godoc is here
https://godoc.org/github.com/docker/distribution#Descriptor. I am not
sure how it never made into this specification.Other types with further fields, such as the manifest descriptor, are
extensions to the descriptor type.—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
/~https://github.com/opencontainers/image-spec/pull/18/files/64b5003c9985ba8714201f1ecc01460770ab5828#r59936055
There was a problem hiding this comment.
Yea, I'll do that. Just reviewing old notifications.
|
haha. I see I added the definitions for the manifest list, but didn't |
I managed to forget adding the file in opencontainers#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
I managed to forget adding the file in opencontainers#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Previously we didn't define what a media type was and the old regular expression (from 818a56a, schema: image manifest, 2016-04-12, opencontainers#18) was stricter than the RFC. The RFC rules are in [1], and the JSON Schema regexp syntax is in [2]. In the new pattern, * [A-Za-z0-9] is restricted-name-first (ALPHA / DIGIT), with ALPHA and DIGIT defined in RFC 5234 [3]. * [A-Za-z0-9!#$&-^_.+] is restricted-name-chars. [1]: https://tools.ietf.org/html/rfc6838#section-4.2 [2]: https://tools.ietf.org/html/draft-wright-json-schema-validation-00#section-3.3 [3]: https://tools.ietf.org/html/rfc5234#appendix-B.1 Signed-off-by: W. Trevor King <wking@tremily.us>
I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
I managed to forget adding the file in opencontainers/image-spec#18 Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
related to #7
testing against https://gist.github.com/vbatts/b3e4fc231fbc92a9cbc28b9184f0b2d2