Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reduce Hash Allocations in PG Instrumentation #232

Merged
merged 2 commits into from
Jan 14, 2023
Merged

fix: Reduce Hash Allocations in PG Instrumentation #232

merged 2 commits into from
Jan 14, 2023

Conversation

arielvalentin
Copy link
Collaborator

@arielvalentin arielvalentin self-assigned this Dec 26, 2022
@arielvalentin arielvalentin marked this pull request as ready for review January 13, 2023 00:08
ericmustin
ericmustin approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment but not blocking, lgtm

instrumentation/pg/lib/opentelemetry/instrumentation/pg/patches/connection.rb Show resolved Hide resolved
@arielvalentin arielvalentin marked this pull request as draft January 13, 2023 16:29
@arielvalentin arielvalentin force-pushed the collection-compact branch 3 times, most recently from aec07e4 to 0c71411 Compare January 14, 2023 16:52
@arielvalentin
chore: Minimize object allocation
cd98a8a 
This change removes allocation of 2 additional hashes per PG SQL span.
@arielvalentin arielvalentin marked this pull request as ready for review January 14, 2023 17:06
@arielvalentin arielvalentin changed the title chore: Enable Style/CollectionCompact fix: Reduce Hash Allocations in PG Instrumentation Jan 14, 2023
ericmustin
ericmustin approved these changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arielvalentin arielvalentin merged commit 53a5b26 into open-telemetry:main Jan 14, 2023
@arielvalentin arielvalentin deleted the collection-compact branch January 14, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmustin ericmustin ericmustin approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees

@arielvalentin arielvalentin

Labels
optimization styleguide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielvalentin @ericmustin