chore: enable Style/CollectionCompact

open-telemetry · Dec 26, 2022 · f9ed8ba · f9ed8ba
1 parent 809e3cd
commit f9ed8ba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -67,7 +67,7 @@ Lint/SymbolConversion:
 Metrics/ParameterLists:
   Enabled: false
 Style/CollectionCompact:
-  Enabled: false
+  Enabled: true
 Style/FetchEnvVar:
   Enabled: false
 Style/GlobalStdStream:

diff --git a/instrumentation/pg/lib/opentelemetry/instrumentation/pg/patches/connection.rb b/instrumentation/pg/lib/opentelemetry/instrumentation/pg/patches/connection.rb
@@ -86,7 +86,7 @@ def span_attrs(kind, *args)
             attrs = { 'db.operation' => validated_operation(operation), 'db.postgresql.prepared_statement_name' => statement_name }
             attrs['db.statement'] = sql unless config[:db_statement] == :omit
             attrs.merge!(OpenTelemetry::Instrumentation::PG.attributes)
-            attrs.reject! { |_, v| v.nil? }
+            attrs.compact!
 
             [span_name(operation), client_attributes.merge(attrs)]
           end
@@ -131,7 +131,7 @@ def client_attributes
             }
             attributes['peer.service'] = config[:peer_service] if config[:peer_service]
 
-            attributes.merge(transport_attrs).reject { |_, v| v.nil? }
+            attributes.merge(transport_attrs).compact
           end
 
           def transport_addr