Revert "[chore] Use crosslink tidylist in make gotidy (#37142)"

[TylerHelmuth]

Reverts #37142 as something with this change is not working as expected. Reverting for now to unblock PRs.

See #37170 and #37172

[jade-guiton-dd]

Could you point to a PR which shows non-deterministic behavior? As in, multiple runs of the CI where make tidylist has different outputs with the same inputs.

[TylerHelmuth]

@jade-guiton-dd #37172 is an example. The CI is failing, telling me to run make tidylist locally, but when I run make tidylist locally again there are no changes.

[jade-guiton-dd]

@TylerHelmuth Do you have untracked changes to any go.mod files in your local copy, compared to main?

[TylerHelmuth]

Do you have changes to any go.mod files in your local copy, compared to main?

No

[jade-guiton-dd]

I see. In that case, it does sound like it's non-deterministic (or maybe platform-dependent).

[TylerHelmuth]

I'm wondering if different go versions affect it. Can you keep working on a fix? I would love not to need to run make gotidy multiple times anymore.

[jade-guiton-dd]

Yes, I'll work on a fix tomorrow, a revert is fine in the meantime. Could you tell me what OS and version of Go you're using (the one used to compile crosslink) so I can try to replicate it?

[TylerHelmuth]

Could you tell me what OS and version of Go you're using (the one used to compile crosslink) so I can try to replicate it?

MacOS 15.1.1 (24B91), Go 1.22.7 (was not able to get CI to match Go 1.22.10 either).

[jade-guiton-dd]

I've figured out the issue: it was indeed a problem with "untracked changes to any go.mod files in your local copy", specifically whether make genotelcontribcol has been run or not (the output contains a go.mod which is .gitignored). I stripped cmd/otelcontribcol from the output of the tool, but it wasn't enough: the difference in the input dependency graph still changes the rest of the output quite significantly. The simplest option is probably for me to add an --exclude flag to the tool to make it completely ignore this module.