Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --skip flag to crosslink tidylist #662

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jade-guiton-dd
Copy link
Contributor

Integration of crosslink tidylist (cf. #642 for context) in collector-contrib encountered issues, because the output depended on the existence of the cmd/otelcontribcol and cmd/oteltestbedcol, which are autogenerated and gitignored. I had manually filtered them from the output, but their presence still caused changes to the order of the other modules.

This PR introduces a new --skip flag to the crosslink tidylist subcommand, similar to the one on the root command, which specifies go.mod files that should be entirely ignored by the command (omitted from the output, but also ignored when analyzing the dependency graph). Using this in contrib should fix the non-determinism issue.

I also introduced two new tests to help check the determinism of the tool: one checking that the tool defaults to alphabetical order in the absence of dependency constraints, and one checking that --skip works as described above.

@jade-guiton-dd jade-guiton-dd requested review from a team as code owners January 14, 2025 12:08
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.89%. Comparing base (74d4b2b) to head (b9659cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
+ Coverage   48.86%   48.89%   +0.03%     
==========================================
  Files          57       57              
  Lines        3381     3383       +2     
==========================================
+ Hits         1652     1654       +2     
  Misses       1568     1568              
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi merged commit c77c83e into open-telemetry:main Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants