Add --skip
flag to crosslink tidylist
#662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of
crosslink tidylist
(cf. #642 for context) in collector-contrib encountered issues, because the output depended on the existence of thecmd/otelcontribcol
andcmd/oteltestbedcol
, which are autogenerated andgitignore
d. I had manually filtered them from the output, but their presence still caused changes to the order of the other modules.This PR introduces a new
--skip
flag to thecrosslink tidylist
subcommand, similar to the one on the root command, which specifiesgo.mod
files that should be entirely ignored by the command (omitted from the output, but also ignored when analyzing the dependency graph). Using this in contrib should fix the non-determinism issue.I also introduced two new tests to help check the determinism of the tool: one checking that the tool defaults to alphabetical order in the absence of dependency constraints, and one checking that
--skip
works as described above.