Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

Update uif-spinner attribute name #102

Closed
andrewconnell opened this issue Jan 16, 2016 · 2 comments
Closed

Update uif-spinner attribute name #102

andrewconnell opened this issue Jan 16, 2016 · 2 comments
Assignees
@jjczopek
Labels
breaking-change

Comments

@andrewconnell
Copy link
Member

The attribute uif-spinnersize should really be uif-spinner-size. Can this get renamed & the demo updated?
@waldekmastykarz
Copy link
Member

Since the directive is called uif-spinner and size is not a directive but a regular attribute how about we called it uif-size to keep it short and consistent with other attributes?

@andrewconnell
Copy link
Member Author

Much better suggestion… make it so :)

@jjczopek jjczopek mentioned this issue Jan 23, 2016
Closed
andrewconnell pushed a commit that referenced this issue Jan 24, 2016
@jjczopek @andrewconnell
feat(spinner): attribute rename & validation
9ce8adc 
Added attribute validation and error logging to the console to address directive guidelines [007](/~https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#directive-attribute-validation) & [008](/~https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#error-messages).

  BREAKING CHANGE: uif-spinner's `uif-spinnersize` attribute changed to `uif-size`.

  Change your code from this:

  ```html
  <uif-spinner uif-spinnersize="large"></uif-spinner>
  ```

  To this:

  ```html
  <uif-spinner uif-size="large"></uif-spinner>
  ```

Closes #100. Closes #102. Closes #120.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jjczopek jjczopek

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jjczopek @andrewconnell @waldekmastykarz