This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Fixed size attribute name, added enum and validation #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewconnell
pushed a commit
that referenced
this pull request
Jan 24, 2016
Added attribute validation and error logging to the console to address directive guidelines [007](/~https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#directive-attribute-validation) & [008](/~https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#error-messages). BREAKING CHANGE: uif-spinner's `uif-spinnersize` attribute changed to `uif-size`. Change your code from this: ```html <uif-spinner uif-spinnersize="large"></uif-spinner> ``` To this: ```html <uif-spinner uif-size="large"></uif-spinner> ``` Closes #100. Closes #102. Closes #120.
|
Manually merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes name for spinner size attribute, adds enum for size and validates attribute value.
Change reflected in demos and added additional tests to cover new enum values.
Closes #102 #100