Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix request-reviews workflow #51135

Merged
merged 1 commit into from
Feb 28, 2025
Merged

ci: fix request-reviews workflow #51135

merged 1 commit into from
Feb 28, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 28, 2025

The team names are not scoped so we must remove the nextcloud/ part. Otherwise it fails with "is not a collaborator".

The team names are not scoped so we must remove the `nextcloud/` part.
Otherwise it fails with "is not a collaborator".

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added 3. to review Waiting for reviews CI labels Feb 28, 2025
@nickvergessen nickvergessen merged commit 951a35c into master Feb 28, 2025
181 of 187 checks passed
@nickvergessen nickvergessen deleted the fix/request-reviews branch February 28, 2025 14:08
@susnux
Copy link
Contributor Author

susnux commented Feb 28, 2025

This time it correctly fetches the team but does not have permissions to assign people.
The documentation is a bit vague on permissions but I think the problem is that github tokens do only have scoped permissions on the current repository, so they cannot fetch the team from organization.

Because with my PAT it works as tested.

I think we need to do the same as for the create-pr-action and use ${{ secrets.COMMAND_BOT_PAT }}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants