-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Automated request for reviews of pull request #50991
Conversation
I think we should also assign some people, when neither backend nor frontend applies. Otherwise we still have PRs that would slip through. |
I was thinking the same, but who to assign? Basically what is currently not handled:
|
My concern was mainly a bunch of the scripts that are used for building, testing or other purposes. |
Yes but who would be a good assignment for (the other PR also does not include any code owner for build scripts anyway). |
The files in build itself are mostly CI or security, I'm happy to help/assist with those (apart from
Edit: Ah, this should be handled by |
Can we merge and try? :) |
Just needs another review, we can drop or adjust anytime :) |
Ensure that every PR we receive gets the correct reviewers assigned. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
dbba713
to
4c99484
Compare
-H "Accept: application/vnd.github+json" \ | ||
-H "X-GitHub-Api-Version: 2022-11-28" \ | ||
'/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/requested_reviewers' \ | ||
-f "team_reviewers[]=nextcloud/server-backend" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not scoped 🤦 should be:
-f "team_reviewers[]=server-backend"
Ensure that every PR we receive gets the correct reviewers assigned.