feat: Return number of bytes written for every operation #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sigh wasm builds are broken |
Is that on me? I saw there's some failures due to 1.63 being the MSRV, not 1.60 anymore. I pushed a commit that pushes the MSRV to 1.63. |
|
wasn’t you, lets see if your fix helps |
|
Ah I vaguely remembered seeing something related recently in rs-ucan. Followed the traces back and found this: Similar changes will probably fix this here, too. Let me commit them real quick. |
|
I think this should be ready to merge ✌️ |
|
I ran CI on my fork, it's running through fine there. I swear I'm done done for good now. |
Merged
dignifiedquire
approved these changes
Sep 1, 2023
|
🎉 |
|
published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is to return
usizefromCarWriter::writeandCarWriter::write_header. Theseusizes indicate the amount of bytes written to the underlyingAsyncWrite.Knowing these numbers is useful to us (at fission), since it allows us to package up car files "until at least X bytes were written into the CAR file".
I added a proptest to make sure that the final CAR file is just as big as all the returned
usizes summed up. (I initially messed up the impl.proptestmakes stuff like this easy to fix though.)