This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
fix: Get chromedriver from a new location
#514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
force-pushed
the
fix/chrome-setup-in-gh-workflows
branch
3 times, most recently
from
9fbc707 to
c10f465
Compare
cdata
force-pushed
the
fix/chrome-setup-in-gh-workflows
branch
from
c10f465 to
0042562
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our workflow script for getting
chromedriverfor our browser-targeted tests broke from under us due to changes in the Chromium project's release processes (see: https://groups.google.com/g/chromedriver-users/c/clpipqvOGjE).We originally cribbed the script from /~https://github.com/SeleniumHQ/selenium/blob/5d108f9a679634af0bbc387e7e3811bc1565912b/.github/actions/setup-chrome/action.yml
However, Selenium has moved to using /~https://github.com/browser-actions/setup-chrome which does not handle setting up
chromedriver.The original mechanism we depended on to discover the correct
chromedriverversion has been replaced by the static JSON published in /~https://github.com/GoogleChromeLabs/chrome-for-testing#json-api-endpointsSo, this change adapts our workflow scripts to use the new mechanism to setup
chromedriver.