Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix MUI Base vale rule #45140

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 29, 2025

A continuation of #45060.

As a side note, there seem to be more to rename.

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 29, 2025
@mui-bot
Copy link

mui-bot commented Jan 29, 2025

Netlify deploy preview

https://deploy-preview-45140--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against eecd2cc

@oliviertassinari oliviertassinari changed the title [core] Fix missed stuff from MUI Base naming clarification [core] Fix MUI Base Vale rule Jan 29, 2025
@oliviertassinari oliviertassinari changed the title [core] Fix MUI Base Vale rule [core] Fix MUI Base vale rule Jan 29, 2025
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat tangential: should we even continue to provide the MUI Base examples at all? If so, we should probably rename those directories as well.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 29, 2025

we should probably rename those directories as well

@mapache-salvaje Agree. Added as point 9 in #44910 (comment).

I imagine that there is space to create an equivalent example in /~https://github.com/mui/base-ui. For example, as far as I know, the Tailwind CSS interaction can be improved by using @utility to have shortcuts. We also need it so people can easily provide reproductions: mui/base-ui#1367.

should we even continue to provide the MUI Base examples at all?

I think we should keep them through 2025. I get that those examples are mostly used by new users but people continue to use the software after it gets deprecated. Once the download ratio between MUI Base and Base UI inverse, 💯 to at least remove 3 of the 4 examples. Added as point 10 in #44910 (comment).

@oliviertassinari oliviertassinari merged commit 247c597 into mui:master Jan 29, 2025
22 of 23 checks passed
@oliviertassinari oliviertassinari deleted the fix-missing-reviews branch January 29, 2025 17:58
oliviertassinari added a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants