-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Rename "Base UI" to "MUI Base" in all text #45060
Conversation
I added a rule for non-breaking space in MUI Base, and replaced all occurrences. I also found few more replacements we can do inside the examples directory that I pushed. We can also rename the examples directories in a follow up PR. |
@mj12albert Some pages have "We strongly advise using the new package instead." Other pages have "Please use the Base UI...". All message copy should be consistent. "Strongly advise" is better. |
|
👍 ~ I updated eslintrc for this |
@@ -12,6 +12,7 @@ swap: | |||
Material UI: Material UI | |||
MUI X: MUI X | |||
Base UI: Base UI | |||
MUI Base: MUI Base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we add rules like this, can we test that they work? This doesn't fail when the text is wrong (assuming I tested this correctly). It needs to be:
MUI Base: MUI Base | |
MUI Base: MUI Base |
Fixed in: #45140.
Part of #44910
Renamed all the text EXCEPT FOR careers page and (old) blog posts