This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 472
Add-on permission dialog does not prompt for host permissions #8323
Comments
So we will need to parse the domains and add "Access your data for sites in * domain" to our permissions. /cc @Amejia481 |
Amejia481
added a commit
to Amejia481/android-components
that referenced
this issue
Sep 11, 2020
for host permissions
Amejia481
added a commit
to Amejia481/android-components
that referenced
this issue
Sep 11, 2020
for host permissions
Amejia481
added a commit
to Amejia481/android-components
that referenced
this issue
Sep 11, 2020
…for host permissions
Amejia481
added a commit
to Amejia481/android-components
that referenced
this issue
Sep 11, 2020
…for host permissions
4 tasks
Amejia481
added a commit
to Amejia481/android-components
that referenced
this issue
Sep 16, 2020
…for host permissions
bors bot
pushed a commit
that referenced
this issue
Sep 16, 2020
8388: Closes #8323: Add-on permission dialog does not prompt for host permissions r=rocketsroger,delphine a=Amejia481 Adapted algorithm from the [desktop implementation](https://searchfox.org/mozilla-central/source/toolkit/components/extensions/Extension.jsm#1488-1568) docs related to host permissions [[1]](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions#Host_permissions) [[2]](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns) Fenix pr mozilla-mobile/fenix#15002 Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Oct 24, 2022
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7 X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7 X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8 X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Oct 24, 2022
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7 X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7 X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8 X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@222637c
JohanLorenzo
pushed a commit
to JohanLorenzo/android-l10n
that referenced
this issue
Oct 25, 2022
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7 X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7 X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8 X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@222637c
JohanLorenzo
pushed a commit
to JohanLorenzo/android-l10n
that referenced
this issue
Oct 25, 2022
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7 X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7 X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8 X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@222637c
JohanLorenzo
pushed a commit
to JohanLorenzo/android-l10n
that referenced
this issue
Oct 25, 2022
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7 X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7 X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8 X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@222637c
JohanLorenzo
pushed a commit
to JohanLorenzo/android-l10n
that referenced
this issue
Oct 25, 2022
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7 X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7 X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8 X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 13, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 13, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 13, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 13, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 14, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 14, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 14, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 14, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 15, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 15, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 15, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 16, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 17, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 17, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 17, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 17, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 17, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 17, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 17, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 17, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
mozilla-l10n-automation-bot
pushed a commit
to mozilla-l10n-automation-bot/android-l10n
that referenced
this issue
Jan 18, 2023
…rmission dialog does not prompt for host permissions X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd X-Channel-Revision: [main] mozilla-mobile/fenix@d039188 X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1 X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@222637c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In #4871 we created a mapping from permissions to their translations.
One thing we missed is host permissions. We just added two new add-ons to Nightly, which only have host permissions. This currently causes us to display an empty "It requires your permission to:".
For example Video Background Play Fix requires the following permissions:
Since we don't have a mapping we don't display any of them. We should fix this before configuring these new add-ons in beta and release.
Desktop displays the following:
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: