Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #8323: Add-on permission dialog does not prompt for host permissions #8388

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Closes #8323: Add-on permission dialog does not prompt for host permissions #8388

merged 1 commit into from
Sep 16, 2020

Conversation

Amejia481
Copy link
Contributor

@Amejia481 Amejia481 commented Sep 11, 2020 •
edited
Loading

Adapted algorithm from the desktop implementation docs related to host permissions [1] [2]

Fenix pr mozilla-mobile/fenix#15002

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Sep 11, 2020
@Amejia481 Amejia481 force-pushed the issue-8323 branch 2 times, most recently from 9ebe59d to 5acfeb2 Compare September 11, 2020 19:59
@Amejia481 Amejia481 mentioned this pull request Sep 11, 2020
Merged
3 tasks
@Amejia481 Amejia481 linked an issue Sep 14, 2020 that may be closed by this pull request
Add-on permission dialog does not prompt for host permissions #8323
Closed
@rocketsroger rocketsroger self-requested a review September 14, 2020 17:29
@rocketsroger rocketsroger self-assigned this Sep 14, 2020
rocketsroger
rocketsroger approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor comments. Thanks!

components/feature/addons/src/main/java/mozilla/components/feature/addons/Addon.kt Show resolved Hide resolved
components/feature/addons/src/main/java/mozilla/components/feature/addons/Addon.kt Outdated Show resolved Hide resolved
components/feature/addons/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@Amejia481
Copy link
Contributor Author

bors r=rocketsroger,delphine

@Amejia481 Amejia481 added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Sep 16, 2020
@bors
Copy link

bors bot commented Sep 16, 2020

Build succeeded:

@bors bors bot merged commit 30dacc6 into mozilla-mobile:master Sep 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonalmeida jonalmeida jonalmeida left review comments

@Delphine Delphine Delphine left review comments

@rocketsroger rocketsroger rocketsroger approved these changes

Assignees

@rocketsroger rocketsroger

Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add-on permission dialog does not prompt for host permissions
4 participants
@Amejia481 @Delphine @jonalmeida @rocketsroger