Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Pocket sponsored stories API updates #12432

Closed
1 of 3 tasks
Mugurell opened this issue Jul 5, 2022 · 1 comment · Fixed by nathanmkaya/android-components#362
Closed
1 of 3 tasks

Pocket sponsored stories API updates #12432

Mugurell opened this issue Jul 5, 2022 · 1 comment · Fixed by nathanmkaya/android-components#362
Assignees
Labels
<pocket> Component: Service-pocket

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jul 5, 2022

There have been recent changes on the backend that we need to support:

  • the requested version of the api is now enforced to be u32.
    We are sending a string and as such we'd get a Json deserialize error: invalid type: string "2", expected u32 at line 1 column 65 error.
  • the Content-Type": "application/json" is now enforced but only for the development server.
    We are already using this header.
  • support automatically choosing to which endpoint to make the requests - development or production.
    Currently all requests are made on the development server but choosing to use the production one base on a debug flag is possible.

┆Issue is synchronized with this Jira Task

@Mugurell Mugurell added the <pocket> Component: Service-pocket label Jul 5, 2022
@Mugurell Mugurell self-assigned this Jul 5, 2022
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 5, 2022
- Enforce the api version being an int instead of a string
- Enforce automatically choosing to which endpoint to make the requests,
development or production.
- Add tests to prevent regressions.
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 5, 2022
- Enforce the api version being an int instead of a string
- Enforce automatically choosing to which endpoint to make the requests,
development or production.
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 5, 2022
- Enforce the api version being an int instead of a string
- Enforce automatically choosing to which endpoint to make the requests,
development or production.
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 6, 2022
- Enforce the api version being an int instead of a string
- Enforce automatically choosing to which endpoint to make the requests,
development or production.
Mugurell added a commit to Mugurell/android-components that referenced this issue Jul 6, 2022
- Enforce the api version being an int instead of a string
- Enforce automatically choosing to which endpoint to make the requests,
development or production.
mergify bot pushed a commit that referenced this issue Jul 7, 2022
- Enforce the api version being an int instead of a string
- Enforce automatically choosing to which endpoint to make the requests,
development or production.
@Mugurell
Copy link
Contributor Author

Mugurell commented Jul 7, 2022

Changes landed. Closing the ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<pocket> Component: Service-pocket
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant