[pull] main from mozilla-mobile:main #362

pull · 2022-07-02T21:10:52Z

See Commits and Changes for more details.

Disable find in page for previous and forward buttons if the query is empty

This reverts commit 465b853. In Glean v50 `testGetValue` methods are actually not gated on test mode (it's still not recommended though and absolutely IS still a test-only API for all intents and purposes). Further it turns out that calling `GleanTestLocalServer` in one test might influence the other test and we're seeing intermittens where `BaselinePingTest` is trying to upload to `localhost:0`, which of course is invalid. I have not yet figured out how we can properly separate out the state. Alternatively we could merge the 2 tests into a single one. Fixes #11340

Image sharing currently only works when sharing to an app but not when using the Android Direct Share feature, where it fails with a SecurityException. "Direct Share" is what Android calls the app created shortcuts, i.e. individual chats from a messaging application. The code pretty much already does the right thing (i.e. setting the FLAG_GRANT_READ_URI_PERMISSION on the target intent as well as the Chooser action, as described in ACTION_CHOOSE Api docs[1]) but there's some platform internals that seem to go wrong here but we can work around it with this patch. https://issuetracker.google.com/issues/151386328 describes a similar Problem, especially #12 in there offers a similar workaround and an explanation: The underlying problem is that ACTION_SEND is using EXTRA_STREAM for the content URI. But the FLAG_GRANT_*_URI_PERMISSION mechanism only works with URIs in Intent.data and Intent.clipData. The framework contains some code that tries to work around this limitation. But it doesn't handle this particular case. Intent.createChooser() migrates the flags and data/clipData from the target Intent, but it does so before the framework had a chance to fix up the target Intent via Intent.migrateExtraStreamToClipData(). And indeed moving the clipData into the inner intent makes Direct Share work and preserves the image preview in the Intent. [1] file:///<SDK-DIR>/docs/reference/android/content/Intent.html#ACTION_CHOOSER If you need to grant URI permissions through a chooser, you must specify the permissions to be granted on the ACTION_CHOOSER Intent in addition to the EXTRA_INTENT inside. This means using setClipData(ClipData) to specify the URIs to be granted as well as FLAG_GRANT_READ_URI_PERMISSION and/or FLAG_GRANT_WRITE_URI_PERMISSION as appropriate.

Decouple this functionality from search suggestions allowing for individual control over the readers used.

Values are also accessed from code, not just from tests.

No accessors needed in tests.

Constructor parameter is never used as a property.

…rogressOverlay view

Update imports for annotations moved to Companion Object.

…he repo migration is done

Ionut Cristian Bedregeanu and others added 30 commits August 24, 2022 06:41

For #12637 - Disable find in page for empty queries

4680638

Disable find in page for previous and forward buttons if the query is empty

Update GeckoView (Nightly) to 106.0.20220824093620.

5342fa8

Import l10n.

acf9a1d

Update GeckoView (Nightly) to 106.0.20220825065712.

b42fc4f

Import l10n.

0ccaebb

Update GeckoView (Nightly) to 106.0.20220826092109.

ce81af2

Update ac-version-for-fenix-beta version to fix sync-strings action

969c6f9

Import l10n.

2f8d02f

Update GeckoView (Nightly) to 106.0.20220827070018.

9b5eb52

Update GeckoView (Nightly) to 106.0.20220827173411.

61d5d3f

Import l10n.

f6e7218

Import l10n.

80a299b

Update GeckoView (Nightly) to 106.0.20220829094551.

3ca3601

update bot name

d5fbf58

Import l10n.

1b9b8b4

Update GeckoView (Nightly) to 106.0.20220830092750.

2e1087e

For #12711 - Use a separate reader for autocomplete suggestions

2026625

Decouple this functionality from search suggestions allowing for individual control over the readers used.

Import l10n.

79c719a

For #12381: Update Gradle, Gradle plugin and kotlin-dsl plugin.

9f116dd

For #12381: Sync android lint version to gradle plugin version.

042e3f3

For #12381: Add mockito and junit dependencies to lint module.

29aad4d

For #12381: Remove VisibleForTesting annotation.

b4d4af8

Values are also accessed from code, not just from tests.

For #12381: Remove VisibleForTesting annotation.

00bf79f

No accessors needed in tests.

For #12381: Replace VisibleForTesting with @get:VisibleForTesting.

a73713b

For #12381: Remove variable declaration.

aed9855

Constructor parameter is never used as a property.

For #12381: Update VisibleForTesting ProductionVisibility.

b7268e3

For #12381: Handle allowBackup, fullBackupContent deprecation.

77a5e17

For #12381: Suppress VectorPath warning.

d6f6b01

MickeyMoz and others added 29 commits October 24, 2022 14:52

Update GeckoView (Nightly) to 108.0.20221024093150.

c8c8776

Update GeckoView (Nightly) to 108.0.20221024212806.

d970ebc

Bug #1795949 - Dismiss ChoiceDialogFragment only when it is attached

5a7ac90

Update GeckoView (Nightly) to 108.0.20221025094808.

ddc7696

Bug 1797273 - Bind OverlayAddOnProgressBinding to the included addonP…

230bc3c

…rogressOverlay view

No issue: Update metrics.md files from glean_parser v6.2.1

f914535

No issue: Update AndroidX Annotation to the latest version.

82d79a6

Update imports for annotations moved to Companion Object.

Update Readability to 0.4.2

760f654

Bug 1796144 - Add setting for cookie banner handling mode

f1a8040

Import l10n.

72d0149

Update GeckoView (Nightly) to 108.0.20221026034746.

abb3490

Glean: Re-export TextMetricType

8fc4e4a

Glean: Re-export rate metric type (and subtypes)

115a49d

Add changelog entry for Glean changes

184adc3

Import l10n.

f3dfcf5

Bug 1776676 - Ship v107.0.0 of the WebCompat System Addon.

8fb574e

Update GeckoView (Nightly) to 108.0.20221026162336.

1218871

Update Glean to 51.7.0.

ae51ebf

Update GeckoView (Nightly) to 108.0.20221026224258.

94afbf7

Import l10n.

caabe57

Update GeckoView (Nightly) to 108.0.20221027095047.

a8035c0

Update Sentry to 6.6.0

cbb5f4e

Import l10n.

635f092

Update GeckoView (Nightly) to 108.0.20221028094453.

1b2d782

Import l10n.

e9c57bf

Update GeckoView (Nightly) to 108.0.20221028212211.

0ae737c

Update GeckoView (Nightly) to 108.0.20221029095010.

7bc88cb

Bug 1798026 - part 1: Don't run geckoview bumps automatically until t…

665a971

…he repo migration is done

Delete CNAME

bb489ef

pull bot merged commit bb489ef into nathanmkaya:main Dec 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] main from mozilla-mobile:main #362

[pull] main from mozilla-mobile:main #362

pull bot commented Jul 2, 2022 •

edited by github-actions bot

Loading

[pull] main from mozilla-mobile:main #362

[pull] main from mozilla-mobile:main #362

Conversation

pull bot commented Jul 2, 2022 • edited by github-actions bot Loading

pull bot commented Jul 2, 2022 •

edited by github-actions bot

Loading