-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update urdf/model.h -> urdf/model.hpp #127
Conversation
Since this URDF deprecation warning change was only added to Rolling via the latest @henningkayser @sjahr Are you guys willing to help get this set up? |
dc33d06
to
888475d
Compare
@sea-bass thank you! I'd be happy to set up those branches, but is it worth it just for missing headers? What do you think about just using include conditions like here /~https://github.com/moveit/moveit2/pull/598/files |
That would work even better! Wasn't aware of those, and can try it out later. Thank you. Also, I already set up those branches, but we can probably delete them if the include conditions work out. EDIT: Yep, that worked perfectly. Done! |
903c198
to
766c8e7
Compare
Seems the deprecation warning came in with a linting PR to the
urdf
repo: ros2/urdf#39