Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update urdf/model.h -> urdf/model.hpp #127

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

sea-bass
Copy link

@sea-bass sea-bass commented Oct 1, 2024

Seems the deprecation warning came in with a linting PR to the urdf repo: ros2/urdf#39

@sea-bass
Copy link
Author

sea-bass commented Oct 1, 2024

Since this URDF deprecation warning change was only added to Rolling via the latest urdf repo changes, we will need to create separate humble / iron branches, and then have jazzy / rolling move on from this change. This is because those branches do not have model.hpp.

@henningkayser @sjahr Are you guys willing to help get this set up?

@sea-bass sea-bass force-pushed the update-urdf-header branch from dc33d06 to 888475d Compare October 1, 2024 12:40
@sea-bass sea-bass changed the title Update urdf/model.h -> urdf/model.hpp Update urdf/model.h -> urdf/model.hpp, add Jazzy and different repo branches to CI Oct 1, 2024
@sea-bass sea-bass changed the title Update urdf/model.h -> urdf/model.hpp, add Jazzy and different repo branches to CI Update urdf/model.h -> urdf/model.hpp, only run CI on Rolling Oct 1, 2024
@sea-bass sea-bass changed the title Update urdf/model.h -> urdf/model.hpp, only run CI on Rolling Update urdf/model.h -> urdf/model.hpp, checkout different branches in different versions in CI Oct 1, 2024
@henningkayser
Copy link
Member

henningkayser commented Oct 2, 2024

@sea-bass thank you! I'd be happy to set up those branches, but is it worth it just for missing headers? What do you think about just using include conditions like here /~https://github.com/moveit/moveit2/pull/598/files

@sea-bass
Copy link
Author

sea-bass commented Oct 2, 2024

@sea-bass thank you! I'd be happy to set up those branches, but is it worth it just for missing headers? What do you think about just using include conditions like here /~https://github.com/moveit/moveit2/pull/598/files

That would work even better! Wasn't aware of those, and can try it out later. Thank you.

Also, I already set up those branches, but we can probably delete them if the include conditions work out.

EDIT: Yep, that worked perfectly. Done!

@sea-bass sea-bass changed the title Update urdf/model.h -> urdf/model.hpp, checkout different branches in different versions in CI Update urdf/model.h -> urdf/model.hpp Oct 2, 2024
@sea-bass sea-bass force-pushed the update-urdf-header branch from 903c198 to 766c8e7 Compare October 2, 2024 12:31
@sea-bass sea-bass mentioned this pull request Oct 2, 2024
@henningkayser henningkayser merged commit adc1719 into ros2 Oct 2, 2024
10 checks passed
@rhaschke rhaschke deleted the update-urdf-header branch October 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants