Various fixes for tests/CI #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overload `ostream << wchar_t*` is deleted in C++20, and previously would print a pointer value instead of the string.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kennykerr
reviewed
Oct 17, 2022
| @@ -63,7 +63,7 @@ namespace | |||
| } | |||
| else | |||
| { | |||
| return static_cast<IObservableVector<K, V>>(winrt::make<custom_observable_map<K, V, Container>>(std::move(values))); | |||
| return static_cast<IObservableMap<K, V>>(winrt::make<custom_observable_map<K, V, Container>>(std::move(values))); | |||
There was a problem hiding this comment.
@dunhor I get the feeling this test path is never tested...
There was a problem hiding this comment.
Hey, man. Sometimes I'm not the one to blame: 2cb852b#diff-1bff145f07a25cc8dc26022e600d05a588e93e8114cd458e410a82c353ed916d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some of the changes that will help adding the Clang CI (#1203) but are more about general fixes which are not specific to Clang.