Add CI test with LLVM 15 clang-cl #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be blocked on llvm/llvm-project#57094 ( |
|
More failures: |
|
C++/WinRT pushes C++ pretty hard in some areas and Clang may not be up to it in all cases. We may need to disable certain tests under Clang... |
sylveon
previously approved these changes
Oct 15, 2022
|
We might also want to report bugs to clang (resume_after, GetMany and weak). Ideally the whole suite would compile and run on both. |
alvinhochun
commented
Oct 15, 2022
|
For test_win7 (async_auto_cancel), this is what I got locally: For test_old (async, Throw_IAsyncAction): (Couldn't dig any deeper) |
|
@kennykerr Can you also allow the action |
|
@alvinhochun done! |
This works on MSVC but not on Clang, not sure if it is a bug. See also: https://devblogs.microsoft.com/oldnewthing/20191219-00/?p=103230
Catch2's assertions rely on exceptions and this exception being thrown inside the custom winrt_throw_hresult_handler causes an abort.
This is also an issue related to the co_await overload resolution.
lld-link doesn't build the test\old_tests\Composable project because it errors out on the /WINMD:NO option. This reverts commit 6b61e42.
Helps figure out which tests crashes.
alvinhochun
force-pushed
the
alvin/test-clang-cl
branch
from
86c7a05 to
aa6467d
Compare
alvinhochun
changed the title
|
I have excluded all code that fails to build with Clang and I believe I have marked every flaky/crashing tests for the Clang build. When building with Clang, all these tests have the |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kennykerr
reviewed
Oct 18, 2022
Comment on lines
-262
to
-264
| <Manifest> | ||
| <AdditionalManifestFiles>app.manifest;%(AdditionalManifestFiles)</AdditionalManifestFiles> | ||
| </Manifest> |
There was a problem hiding this comment.
Why did this get dropped? This was to enable long path support.
There was a problem hiding this comment.
The manifest is already included in the project as a "Manifest file" type (
cppwinrt/cppwinrt/cppwinrt.vcxproj
Line 118 in aa6467d
/manifestinput:app.manifest flag passed to link.exe.
This extra AdditionalManifestFiles attribute is in a conditional "Debug|x64" block so it doesn't apply to other configurations anyway. It also makes lld-link produce a broken binary (filed llvm/llvm-project#58444), which is the main reason for removing this. (Though I ended up not switching to lld-link anyway due to llvm/llvm-project#58445. I guess this may be fixable in the project file but there's no rush to enable this.)
|
I really appreciate the way you've staged the changes in a series of manageable PRs. 👍 |
kennykerr
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes and workarounds are needed to get Clang to build some of the tests. There are still some outstanding issues:
test\test\GetMany.cppandtest\test_win7\GetMany.cpp, we get a recursive template instantiation:test\old_tests\UnitTests\weak.cpp, there is an incomplete type error:I will probably need some help figuring these out.