Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct example names for localizedAttributes #3087

Conversation

ellnix
Copy link
Contributor

@ellnix ellnix commented Jan 1, 2025

Currently, the examples are missing due to being referred to by the wrong names. See the correct names in meilisearch-js.

Links to the live site for convenience:
https://www.meilisearch.com/docs/reference/api/settings#example-19
https://www.meilisearch.com/docs/reference/api/settings#example-20

Currently, the examples are missing due to being referred to by the
wrong names. See the correct names in [meilisearch-js](/~https://github.com/meilisearch/meilisearch-js/blob/896b5c0cf3479a04a1b137394796a5f34b161210/.code-samples.meilisearch.yaml#L802).
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in responding, the @meilisearch/docs-team was on holiday the past couple of weeks.

LGTM, thanks for the contribution!

@guimachiavelli guimachiavelli merged commit 639eec6 into meilisearch:main Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants