Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Localized Attributes code sample names #3092

Closed
wants to merge 1 commit into from

Conversation

danFbach
Copy link
Contributor

@danFbach danFbach commented Jan 8, 2025

Pull Request

What does this PR do?

  • This fixes incorrect names that fail to reference .code-samples.meilisearch.yaml defined names

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

…eilisearch.yaml

This fixes incorrect names that fail to reference .code-samples.meilisearch.yaml defined names
@danFbach
Copy link
Contributor Author

danFbach commented Jan 8, 2025

fixes #3026

@guimachiavelli
Copy link
Member

Thanks for the contribution, @danFbach, it's much appreciated!

However, this was fixed earlier today when I merged #3087, so this PR is no longer needed. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants