Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-844]: Added server testcase for store/welcome_store.go #429

Merged
merged 18 commits into from
Jan 16, 2025

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Nov 5, 2024

Summary

Added server testcase for store/welcome_store.go

@Kshitij-Katiyar Kshitij-Katiyar added the 2: Dev Review Requires review by a core committer label Nov 5, 2024
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Nov 5, 2024
calendar/store/welcome_store_test.go Outdated Show resolved Hide resolved
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI errors to fix.

calendar/store/welcome_store_test.go Outdated Show resolved Hide resolved
"github.com/mattermost/mattermost-plugin-mscalendar/calendar/utils/bot/mock_bot"
)

var MockString = mock.AnythingOfType("string")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the matched by here as well. Eventually we will move these into a util file and re-use.

Copy link
Contributor Author

@Kshitij-Katiyar Kshitij-Katiyar Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wiggin77 Moved the mock to the util file, please have a look

Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 16, 2025
@raghavaggarwal2308 raghavaggarwal2308 merged commit 39fb290 into master Jan 16, 2025
8 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-844 branch January 16, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants