[MM-844]: Added server testcase for store/welcome_store.go #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [MM-843]: Added server testcase for kvstore/plugin_store.go file * [MM-843]: removed ununsed vars
…lendar into add_plugin_store.go_testcase
…/mattermost-plugin-mscalendar into MM-844
…lendar into MM-844
raghavaggarwal2308
approved these changes
Dec 9, 2024
wiggin77
requested changes
Dec 10, 2024
wiggin77
requested changes
Dec 10, 2024
| "github.com/mattermost/mattermost-plugin-mscalendar/calendar/utils/bot/mock_bot" | ||
| ) | ||
|
|
||
| var MockString = mock.AnythingOfType("string") |
There was a problem hiding this comment.
Can you put the matched by here as well. Eventually we will move these into a util file and re-use.
There was a problem hiding this comment.
@wiggin77 Moved the mock to the util file, please have a look
raghavaggarwal2308
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added server testcase for store/welcome_store.go